Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert add release-plz config. #907

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Jan 20, 2024

Reverts #906

We can't publish Jumpy to crates.io yet, and release-plz expects that. We'll do releases manually for now.

@zicklag zicklag merged commit 6882ca9 into main Jan 20, 2024
8 checks passed
@zicklag zicklag deleted the revert-906-ci/release-plz branch January 20, 2024 00:56
@orhun
Copy link
Member

orhun commented Jan 20, 2024

You can probably disable crates.io releases by doing:

publish = false

See: https://release-plz.ieni.dev/docs/config#the-publish-field

@orhun
Copy link
Member

orhun commented Jan 20, 2024

Ah, I just saw that you already did that. Well, what was the problem then? (just curious :3)

@zicklag
Copy link
Member Author

zicklag commented Jan 20, 2024

Well, it seems like even with publish = false it tries to download the latest released package from crates.io to compare and calculate the next version or something. I feel like that shouldn't be done if publish = false, though.

It's probably worth opening an issue. I'd like to get the release PR workflow going for Jumpy and Bones.

@orhun
Copy link
Member

orhun commented Jan 20, 2024

Definitely, I'd say shoot them and issue to get this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants