[FIX] - replace lodash merge with recursive assign 2 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2020 15:17
This reverts commit 39f208a.
|
That's some nice detective work, Alon. |
added 2 commits
April 2, 2020 16:52
alonfixler
changed the title
alonfixler
changed the title
|
👉 View analysis in DeepCode’s Dashboard |
omrilotan
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 39f208a and replaces usage of lodash merge with version 2 of recursive assign.
lodash has performance issues:
lodash/lodash#1865
reduxjs/redux#1262 (comment)
Since this change deploys to gig page perseus raise the cpu dramatically which result in massive amount of timeouts. (In the image below you can see the results of 2 faulty deploys):
I isolated all the dependencies that were added in recent days in gig page and tested on dev the following PR which explicitly add version 1.8.2 of i18n to gig page. When deploying in dev I've noticed an increment in cpu (the orange line) which went down only after deploying a different tag (the yellow tag):
