Skip creation of new hosted zone for ACM certificate requests #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarojasm95
requested review from
BandarenkaDaniil,
sergey-korenets-fivestars and
vitali-federau-fivestars
drytdubs
approved these changes
Apr 29, 2024
The code being removed here creates a separate hosted zone when creating an acm cert, external dns does not work with separate hosted zones - so this code basically breaks external dns for new namespaces (specifically when ACM is involved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use dedicated hosted zones for namespace management - however the certificate command still creates a dedicated hosted zone.
This PR removes the dedicated hosted zone logic