Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The hubspot__contacts calls upon the contact_merge_audits even though the table has been deprecated from the connector #97

Closed
2 of 4 tasks
elanfivetran opened this issue Feb 28, 2023 · 3 comments

Comments

@elanfivetran
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Per the HubSpot Release Notes, Fivetran deprecated the CONTACT_MERGE_AUDIT table.

However, in the hubspot__contacts.sql model that exists in this package the CONTACT_MERGE_AUDIT table is still being referenced if hubspot_contact_merge_audit_enabled is marked as True in dbt_project.yml. Since most users moving forward will not have the CONTACT_MERGE_AUDIT in their schema, hubspot_contact_merge_audit_enabled should have a default of False.

Relevant error log or model output

No response

Expected behavior

Since most users moving forward will not have the CONTACT_MERGE_AUDIT in their schema, hubspot_contact_merge_audit_enabled should have a default of False.

dbt Project configurations

They are configured to the default settings.

Package versions

n/a

What database are you using dbt with?

bigquery

dbt Version

n/a

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-reneeli
Copy link
Contributor

Following office hours with customer running into duplicates resulting from the same issue, tagging @uxdi-rajan here

@fivetran-jamie
Copy link
Collaborator

the fix for this should officially be in v0.9.0 of the package!

@uxdi-rajan
Copy link

Thank you guys for working on this. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants