Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/owner-variable #129

Merged
merged 3 commits into from
Dec 18, 2023
Merged

bug/owner-variable #129

merged 3 commits into from
Dec 18, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Dec 12, 2023

PR Overview

This PR will address the following Issue/Feature: #128

This PR will result in the following new package version:

  • v0.15.1
  • This is to correct a variable issue. If a user had used it before, they would get an error that this fixes. If they never used it, there will be no changes for them.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

PR #129 includes the following updates:

  • Updated model int_hubspot__deals_enhanced so that fields from the OWNER source are not included when hubspot_owner_enabled is set to false.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • Was able to reproduce error, and error was resolved with these changes.
  • Also see ticket for validation link.

@fivetran-catfritz fivetran-catfritz self-assigned this Dec 12, 2023
@fivetran-catfritz fivetran-catfritz linked an issue Dec 12, 2023 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz these changes look great! I just made some slight modifications to the CHANGELOG and also included the auto-release github action for easier release.

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 858e588 into main Dec 18, 2023
2 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the bug/owner-variable branch December 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Include Owner variable to disable int_hubspot__deals_enhanced model
2 participants