Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Deleted Deal Pipelines and Deal Pipeline Stages #94

Closed
wants to merge 1 commit into from
Closed

Restore Deleted Deal Pipelines and Deal Pipeline Stages #94

wants to merge 1 commit into from

Conversation

jamesrayoub
Copy link
Contributor

@jamesrayoub jamesrayoub commented Dec 22, 2022

Are you a current Fivetran customer?
Yes, Dandelion Energy

What change(s) does this PR introduce?
Restores deleted deal pipelines and deal pipeline stages to stg_hubspot__deal_pipeline and stg_hubspot__deal_pipeline_stage, respectively. Repurposes the is_active boolean column to return the inverse of _fivetran_deleted given HubSpot hard deletes pipelines and is_active is always true (in our instance at least).
Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

This should not cause any of the uniqueness or null tests to fail for either object unless users somehow delete and re-create pipelines or stages with the same enum/ID (I don't believe this is possible anymore)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood
🕵️‍♂️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@jamesrayoub jamesrayoub changed the title restore deleted and change is_active flag Restore Deleted Deal Pipelines and Deal Pipeline Stages Dec 22, 2022
@fivetran-sheringuyen
Copy link
Contributor

Hey @jamesrayoub, thank you for your work on this PR! I have actually been working on a change for a different issue that I suspect may help you get what you need here. Would you like to take a look at and maybe test out this PR and see if it would help get you what you need?

@jamesrayoub jamesrayoub mentioned this pull request Jan 9, 2023
14 tasks
@jamesrayoub jamesrayoub closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants