Add additional fields #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmongerlyra
force-pushed
the
lyra_addl_fields
branch
from
b1a638e
to
8a58dc2
Compare
4 tasks
|
Moved commit to this PR as requested. #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Jared Monger, Lyra Health
Link the issue/feature request which this PR is meant to address
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
This PR adds commonly used fields to the balance sheet, income statement, and transaction details models. See full list and explanations below.
Dependent on this related PR: fivetran/dbt_netsuite_source#54.
models/netsuite2/intermediate/base/int_netsuite2__transaction_lines.sql
transaction_accounting_lines.exchange_rate: Exchange rate used on the transactionmodels/netsuite2/netsuite2__balance_sheet.sql
subsidiaries.full_name: Full hierarchical name of the subsidiaryaccounts.display_name: Account name without number or hierarchyis_account_leftside: Boolean indicating if account has a native debit balancemodels/netsuite2/netsuite2__transaction_details.sql
transactions.is_reversal: Boolean indicating line is reversaltransactions.reversal_transaction_id: Transaction ID of the counterparty in a reversing pairtransactions.reversal_date: Transaction Date of the counterparty in a reversing pairtransactions.is_reversal_defer: Boolean indicating reversal deferraltransaction_lines.is_eliminate: Boolean indicating line will auto-eliminatedepartments.full_name: Full hierarchical name of the departmentsubsidiaries_currencies.symbol: Currency of the subsidiarytransaction_lines.netamount: Net amount of transaction lineHow did you validate the changes introduced within this PR?
Lyra maintains a fork of this repository. These changes were tested and validated there.
Which warehouse did you use to develop these changes?
Snowflake
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)