Expand authentication with mTLS #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 92.49% 94.39% +1.90%
==========================================
Files 145 143 -2
Lines 10245 9909 -336
==========================================
- Hits 9476 9354 -122
+ Misses 769 555 -214 ☔ View full report in Codecov by Sentry. |
ekneg54
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Thank you for your rock solid work 👍
I added a quickstart setup because I needed it to check if your implementation works against real web servers with client side authentication.
And what should I say: It works!!! Congratulations!
I also updated the Changelog.
And I have some considerations on your tests. Please have a look.
add suggestions from review Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Co-authored-by: Jörg Zimmermann <101292599+ekneg54@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the authentication methods should be expanded with mTLS.
ToDos: