From 158fc34cae858cf8d0b5d3b5155763e02454779a Mon Sep 17 00:00:00 2001 From: Luan Nico Date: Sat, 26 Aug 2023 03:35:03 -0700 Subject: [PATCH] refactor: Enable new DCM rule: avoid-cascade-after-if-null (#2676) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Enable new DCM rule: avoid-cascade-after-if-null Reference: https://dcm.dev/docs/rules/common/avoid-cascade-after-if-null/ --- packages/flame_jenny/jenny/test/test_scenario.dart | 3 +-- packages/flame_lint/lib/analysis_options_with_dcm.yaml | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flame_jenny/jenny/test/test_scenario.dart b/packages/flame_jenny/jenny/test/test_scenario.dart index ff69e6bb914..60499653be9 100644 --- a/packages/flame_jenny/jenny/test/test_scenario.dart +++ b/packages/flame_jenny/jenny/test/test_scenario.dart @@ -19,8 +19,7 @@ Future testScenario({ List? commands, YarnProject? yarn, }) async { - final yarnProject = yarn ?? YarnProject() - ..strictCharacterNames = false; + final yarnProject = (yarn ?? YarnProject())..strictCharacterNames = false; commands?.forEach(yarnProject.commands.addOrphanedCommand); Future testBody() async { diff --git a/packages/flame_lint/lib/analysis_options_with_dcm.yaml b/packages/flame_lint/lib/analysis_options_with_dcm.yaml index 87f3f51acd8..c98046bf488 100644 --- a/packages/flame_lint/lib/analysis_options_with_dcm.yaml +++ b/packages/flame_lint/lib/analysis_options_with_dcm.yaml @@ -6,5 +6,6 @@ dart_code_metrics: rules: # dart rules - avoid-banned-imports + - avoid-cascade-after-if-null # flutter rules - prefer-define-hero-tag \ No newline at end of file