feat: Whitelist textures #3505
Open
feat: Whitelist textures #3505
+77
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Feb 21, 2025
| @@ -15,6 +15,7 @@ A flame plugin to import sprite sheets generated by <a href="https://github.com/ | |||
| <a title="Test" href="https://github.com/flame-engine/flame/actions?query=workflow%3Acicd+branch%3Amain"><img src="https://github.com/flame-engine/flame/workflows/cicd/badge.svg?branch=main&event=push"/></a> | |||
| <a title="Discord" href="https://discord.gg/pxrBmy4"><img src="https://img.shields.io/discord/509714518008528896.svg"/></a> | |||
| <a title="Melos" href="https://github.com/invertase/melos"><img src="https://img.shields.io/badge/maintained%20with-melos-f700ff.svg"/></a> | |||
| <a title="AI Assist" href="https://app.commanddash.io/agent/flame_engine"><img src="https://img.shields.io/badge/AI-Code%20Assist-EB9FDA.svg"></a> | |||
There was a problem hiding this comment.
This should be removed, since it isn't in service anymore. (You probably based your commit off an old commit)
| @@ -54,6 +80,23 @@ class TexturePackerAtlas { | |||
| ); | |||
| } | |||
|
|
|||
| /// Loads the atlas that resides on the [path] and | |||
| /// returns a new [TextureAtlasData]. | |||
| @@ -1,7 +1,7 @@ | |||
| name: flame_texturepacker | |||
| resolution: workspace | |||
| description: A simple plugin for the Flame Engine to import spritesheets generated by the TexturePacker tool. | |||
| version: 4.1.6 | |||
| version: 4.2.0 | |||
There was a problem hiding this comment.
This is done automatically by Melos, no need to bump this
Comment on lines
-15
to
+20
| sdk: ">=3.6.0 <4.0.0" | ||
| flutter: ">=3.27.1" | ||
| sdk: ">=3.5.3 <4.0.0" | ||
| flutter: ">=3.24.3" | ||
|
|
||
| dependencies: | ||
| collection: ^1.17.1 | ||
| flame: ^1.25.0 | ||
| flame: ^1.22.0 |
There was a problem hiding this comment.
All dependencies should stay the same as before
| bool useOriginalSize = true, | ||
| String assetsPrefix = 'images/', | ||
| List<String> whiteList = const [], |
There was a problem hiding this comment.
I don't think this is passed anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the optional ability to whitelist relative path names to shrink an atlas down to contain only the images you need. This saves significantly on memory usage with large texture packs.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues