add crash when failure in list or watch of kubernetes api server #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Valid enhancement, but we should probably use the informer factory from client-go tools. |
|
This fix is crucial! I'm struggling with this issue since I first created a windows based kubelet! |
|
Not sure if we should Exit. Can we use the 'context' and cancel it instead? @Oats87 PTAL |
|
@rajatchopra Looking at this, I think it is safe to merge this PR with the idea to perform a future enhancement to move to utilizing the nodeInformer factory, although interestingly in |
rajatchopra
reviewed
Sep 17, 2020
| return ksm.client.CoreV1().Nodes().List(options) | ||
| obj, err := ksm.client.CoreV1().Nodes().List(options) | ||
| if err != nil { | ||
| glog.Exit(err, "failed to list nodes in newKubeSubnetManager") |
There was a problem hiding this comment.
Why quit? This should recover on its own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address "Flanneld doesn't reconnect to the apiserver" - #1272
Add crash when failure in list or watch when talking to kubernetes api server. This should result in a retry loop for the connection (due to flannel being restarted).
Ideally the retry loop should be fully encapsulated inside flannel, however I didn't have much time to fix this problem. And it has been a month and no one has offered a better solution. I hope that this PR sparks that.
Todos
- [ ] Tests- [ ] DocumentationRelease Note