Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner, core, params: enable empty blocks + Developer Chain Config #36

Merged
merged 2 commits into from
Sep 19, 2023
Merged

miner, core, params: enable empty blocks + Developer Chain Config #36

merged 2 commits into from
Sep 19, 2023

Conversation

dmarzzz
Copy link
Member

@dmarzzz dmarzzz commented Sep 18, 2023 •
edited
Loading

📝 Summary

  • removes empty block (txn len = 0) break inside miner/worker loop on Suave Chain for security reasons
  • Adds DeveloperSuaveChainConfig with Clique.Period = 0 which will avoid mining empty blocks

📚 References

  • not progressing the chain creates multiple security vulnerabilities, one example [1].
  • I have seen and agree to CONTRIBUTING.md

@ferranbt ferranbt self-requested a review September 19, 2023 12:23
@dmarzzz dmarzzz changed the title miner: remove empty block breaks miner, core, params: enable empty blocks + Developer Chain Config Sep 19, 2023
@dmarzzz dmarzzz marked this pull request as ready for review September 19, 2023 12:50
@dmarzzz dmarzzz requested a review from Ruteri September 19, 2023 12:53
@dmarzzz dmarzzz merged commit 8f443af into main Sep 19, 2023
4 checks passed
@dmarzzz dmarzzz deleted the dmarz/seal-empty-blocks branch September 19, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferranbt ferranbt ferranbt approved these changes

@Ruteri Ruteri Awaiting requested review from Ruteri Ruteri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarzzz @ferranbt