Skip to content

tests: Add batch size 1 cases to test_trtllm_gen_attention.py that fail, marked xfail #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzh119 merged 3 commits into from
Oct 9, 2025
Merged

tests: Add batch size 1 cases to test_trtllm_gen_attention.py that fail, marked xfail #1897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
034bb83
Test cases for trtllm attention errors
bkryu Oct 6, 2025
5fd31a5
Cleaning up comment
bkryu Oct 6, 2025
abbd125
Add bs1 as separate test case
bkryu Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 68 additions & 2 deletions tests/attention/test_trtllm_gen_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ def test_trtllm_batch_prefill(
)
@pytest.mark.parametrize("enable_pdl", [True, False, None])
@pytest.mark.parametrize("enable_sink", [True, False])
@pytest.mark.parametrize("max_in_kv_len", [110])
def test_trtllm_batch_decode(
kv_layout,
batch_size,
Expand All @@ -577,6 +578,7 @@ def test_trtllm_batch_decode(
kv_dtype,
enable_pdl,
enable_sink,
max_in_kv_len,
):
compute_capability = get_compute_capability(torch.device(device="cuda"))
if compute_capability[0] != 10:
Expand All @@ -589,12 +591,11 @@ def test_trtllm_batch_decode(
# Set up test parameters
torch.manual_seed(0)
head_dim = 128
MAX_IN_KV_LEN = 110

# Generate random sequence lengths
num_qo_heads = num_kv_heads * head_grp_size
q_lens, in_kv_lens, seq_lens = generate_seq_lens_decode(
batch_size, q_len_per_req, MAX_IN_KV_LEN
batch_size, q_len_per_req, max_in_kv_len
)

# Create query tensor and related data
Expand Down Expand Up @@ -805,6 +806,56 @@ def test_trtllm_batch_decode(
assert (workspace_buffer[: 8192 * 256 * 4].cpu().numpy() == 0).all()


@pytest.mark.parametrize("kv_layout", ["HND"]) # trtllm-gen only support HND
@pytest.mark.parametrize(
"batch_size,q_len_per_req,page_size,num_kv_heads,head_grp_size",
[
(1, 1, 16, 8, 8),
],
)
@pytest.mark.parametrize("window_left", [-1])
@pytest.mark.parametrize(
"q_dtype,kv_dtype,o_dtype",
[
("fp8", "fp8", "fp8"),
],
)
@pytest.mark.parametrize("enable_pdl", [None])
@pytest.mark.parametrize("enable_sink", [False])
@pytest.mark.parametrize("max_in_kv_len", [8192])
def test_trtllm_batch_decode_bs1(
kv_layout,
batch_size,
q_len_per_req,
page_size,
num_kv_heads,
head_grp_size,
window_left,
q_dtype,
o_dtype,
kv_dtype,
enable_pdl,
enable_sink,
max_in_kv_len,
):
pytest.xfail("trtllm-gen decode gets incorrect output with bs1")
test_trtllm_batch_decode(
kv_layout,
batch_size,
q_len_per_req,
page_size,
num_kv_heads,
head_grp_size,
window_left,
q_dtype,
o_dtype,
kv_dtype,
enable_pdl,
enable_sink,
max_in_kv_len,
)


@pytest.mark.parametrize("batch_size", [4, 128, 256])
@pytest.mark.parametrize("s_qo", [32, 64, 87])
@pytest.mark.parametrize("s_kv", [32, 64, 87])
Expand Down Expand Up @@ -938,6 +989,21 @@ def test_trtllm_gen_prefill_deepseek(
assert (workspace_buffer[: 8192 * 256 * 4].cpu().numpy() == 0).all()


@pytest.mark.parametrize("batch_size", [1])
@pytest.mark.parametrize("s_qo", [1024])
@pytest.mark.parametrize("s_kv", [1024])
@pytest.mark.parametrize("num_kv_heads", [128])
@pytest.mark.parametrize("head_grp_size", [1])
@pytest.mark.parametrize("causal", [True, False])
def test_trtllm_gen_prefill_deepseek_bs1(
batch_size, s_qo, s_kv, num_kv_heads, head_grp_size, causal
):
pytest.xfail("trtllm-gen prefill triggers an IMA with bs1")
test_trtllm_gen_prefill_deepseek(
batch_size, s_qo, s_kv, num_kv_heads, head_grp_size, causal
)


if __name__ == "__main__":
test_trtllm_batch_prefill("HND", 128, 32, 2, 5, -1, "fp16", "fp16", "fp16", False)
test_trtllm_batch_decode("HND", 256, 3, 64, 4, 5, -1, "fp8", "fp8", "fp8", True)