From 99aeeed5398bc79d362e79ef59f09ecf6a95c049 Mon Sep 17 00:00:00 2001 From: Krzesimir Nowak Date: Fri, 29 Sep 2023 13:53:26 +0200 Subject: [PATCH] show-changes: Fix excessive quoting Single quotes inside a line like below are treated as a part of the value: : "${foo:='bar'}" If foo is empty or unset then it will be set to "'bar'", instead of just "bar". This resulted in the script complaining that git can't operate on directory "'scripts'". --- show-changes | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/show-changes b/show-changes index daa1c43..49ead14 100755 --- a/show-changes +++ b/show-changes @@ -12,9 +12,9 @@ if [ $# -lt 1 ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then exit 1 fi -: "${SCRIPTS_REPO:='scripts'}" -: "${COREOS_OVERLAY_REPO:='coreos-overlay'}" -: "${PORTAGE_STABLE_REPO:='portage-stable'}" +: "${SCRIPTS_REPO:=scripts}" +: "${COREOS_OVERLAY_REPO:=coreos-overlay}" +: "${PORTAGE_STABLE_REPO:=portage-stable}" OLD="$1" NEW="${2-HEAD}"