Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cxx_cmd which parallels cc_cmd #144

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

flavorjones
Copy link
Owner

@flavorjones flavorjones commented May 29, 2024

Add a cxx_cmd. Use it for configuring CMake, removing the logic added in #130 for host-specific binary detection.

Related to #141.

@flavorjones flavorjones changed the title Add cxx_command which parallels cc_command Add cxx_cmd which parallels cc_cmd May 29, 2024
@flavorjones
Copy link
Owner Author

@stanhu Do you want to give this branch a try on your projects before I merge, to make sure I'm not breaking anything?

@flavorjones flavorjones mentioned this pull request May 29, 2024
@stanhu
Copy link
Contributor

stanhu commented May 29, 2024

@flavorjones Sure, I'm running a test with the re2 gem now.

stanhu added a commit to stanhu/re2 that referenced this pull request May 29, 2024
This attempts to launch all builds with
flavorjones/mini_portile#144.
@stanhu
Copy link
Contributor

stanhu commented May 29, 2024

I tested locally, and the CI runs in mudge/re2#151 look good. The failures are due to not having mini_portile2 available as a gem. We can re-test with a release.

@flavorjones
Copy link
Owner Author

@stanhu Thanks for testing! I'll get an RC out this week.

@flavorjones flavorjones merged commit c451dde into main May 29, 2024
34 checks passed
@flavorjones flavorjones deleted the flavorjones-cxx-command branch May 29, 2024 21:58
@flavorjones
Copy link
Owner Author

flavorjones commented May 31, 2024

@stanhu I just released v2.8.7.rc1. If you're able to run that through re2 CI to confirm it's OK for you then I will cut a final release.

Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.

Edit: that PR is #146.

@stanhu
Copy link
Contributor

stanhu commented May 31, 2024

Thanks! I created mudge/re2#153 to test.

Side note: I'm going to try to set up a downstream CI workflow to test re2, sqlite3, and nokogiri.

Awesome, great idea. FYI @mudge

@stanhu
Copy link
Contributor

stanhu commented May 31, 2024

v2.8.7.rc1 seems to work fine.

@flavorjones
Copy link
Owner Author

@stanhu Thank you! The downstream integration tests are live, FYI: https://github.com/flavorjones/mini_portile/actions/runs/9324948020

@flavorjones
Copy link
Owner Author

v2.8.7 final is out. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants