Merge pull request #411 from flexion/sprint-48.5

Sprint 48.5

.circleci/config.yml

@@ -616,9 +616,6 @@ jobs:
       - run:
           name: 'Cypress Smoke Tests'
           command: npm run cypress:smoketests
-      - run:
-          name: 'Cypress Public Smoke Tests'
-          command: npm run cypress:smoketests:public
       - run:
           name: 'Pa11y Smoke Tests'
           command: npm run test:pa11y:smoketests --prefix=web-client/pa11y/

.eslintrc.js

@@ -29,6 +29,7 @@ module.exports = {
       rules: {
         'jest/expect-expect': 'off',
         'jest/valid-expect': 'off',
+        'jest/valid-expect-in-promise': 'off',
         'promise/always-return': 'off',
         'promise/catch-or-return': 'off',
       },

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,56 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**In which environment did you see this bug?**
+
+**What were you doing when you discovered this bug? (Demoing, smoke tests, testing other functionality, etc.)**
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Actual behavior**
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.
+
+Process for logging bug:
+* Complete the above information
+* Add a severity tag (Critical, High Severity, Medium Severity or Low Severity). See below for priority definition. 
+* For critical and high-severity bugs, communicate immediately to project manager or tech lead
+* For medium or low severity, review daily during stand up
+
+Severity Definition:
+* Critical defects usually block an entire system’s or module’s functionality, and testing cannot proceed further without such a defect being fixed. An example of a critical defect is an application’s returning a server error message after a login attempt.
+* High-severity defects affect key functionality of an application, and the app behaves in a way that is strongly different from the one stated in the requirements, for instance, an email service provider does not allow adding more than one email address to the recipient field.
+* Medium-severity defects are identified in case a minor function does not behave in a way stated in the requirements. An example of such a defect is a broken link in an application’s Terms and Requirements section.
+* Low-severity defects are primarily related to an application’s UI and may include such an example as a slightly different size or color of a button.

cypress-smoketests.json

@@ -12,5 +12,6 @@
   "defaultCommandTimeout": 20000,
   "requestTimeout": 20000,
   "viewportWidth": 1200,
-  "viewportHeight": 900
+  "viewportHeight": 900,
+  "retries": 3
 }

cypress-smoketests/fixtures/caseMigrations.js

@@ -9,7 +9,7 @@ const { MOCK_CASE } = require('../../shared/src/test/mockCase');
 exports.BASE_CASE = {
   ...MOCK_CASE,
   associatedJudge: CHIEF_JUDGE,
-  caseCaption: 'A Migrated Case',
+  caseCaption: `${faker.name.findName()}, Petitioner`,
   preferredTrialCity: 'Washington, District of Columbia',
 };
 

cypress-smoketests/integration/court-issued-documents.spec.js

@@ -1,9 +1,13 @@
 const {
-  addDocketEntryForOrderAndServe,
+  addDocketEntryForOrderAndSaveForLater,
   addDocketEntryForOrderAndServePaper,
+  addDocketEntryForUploadedPdfAndServe,
+  addDocketEntryForUploadedPdfAndServePaper,
   createOrder,
   editAndSignOrder,
   goToCaseDetail,
+  serveCourtIssuedDocketEntry,
+  uploadCourtIssuedDocPdf,
 } = require('../support/pages/case-detail');
 const {
   closeScannerSetupDialog,
@@ -88,9 +92,7 @@ describe('Petitions clerk', () => {
   });
 });
 
-//failing because of new tab functionality. skipped until we have the smoke tests discussion
-// eslint-disable-next-line jest/no-disabled-tests
-describe.skip('Docket Clerk', () => {
+describe('Docket Clerk', () => {
   before(async () => {
     const results = await getUserToken(
       'docketclerk1@example.com',
@@ -104,16 +106,27 @@ describe.skip('Docket Clerk', () => {
   });
 
   it('should be able to create an order on the electronically-filed case and serve it', () => {
-    goToCaseDetail(testData.createdDocketNumber);
-    createOrder();
+    createOrder(testData.createdDocketNumber);
     editAndSignOrder();
-    addDocketEntryForOrderAndServe();
+    addDocketEntryForOrderAndSaveForLater();
+    serveCourtIssuedDocketEntry();
   });
 
   it('should be able to create an order on the paper-filed case and serve it', () => {
-    goToCaseDetail(testData.createdPaperDocketNumber);
-    createOrder();
+    createOrder(testData.createdPaperDocketNumber);
     editAndSignOrder();
     addDocketEntryForOrderAndServePaper();
   });
+
+  it('should be able to upload a court-issued order pdf on the electronically-filed case and serve it', () => {
+    goToCaseDetail(testData.createdDocketNumber);
+    uploadCourtIssuedDocPdf();
+    addDocketEntryForUploadedPdfAndServe();
+  });
+
+  it('should be able to upload a court-issued order pdf on the paper-filed case and serve it', () => {
+    goToCaseDetail(testData.createdPaperDocketNumber);
+    uploadCourtIssuedDocPdf();
+    addDocketEntryForUploadedPdfAndServePaper();
+  });
 });

cypress-smoketests/integration/search.spec.js

@@ -0,0 +1,124 @@
+const {
+  addDocketEntryAndServeOpinion,
+  createOpinion,
+  gotoAdvancedPractitionerSearch,
+  gotoAdvancedSearch,
+  goToOpinionSearch,
+  searchByDocketNumber,
+  searchByPetitionerName,
+  searchByPractitionerbarNumber,
+  searchByPractitionerName,
+  searchOpinionByKeyword,
+} = require('../support/pages/advanced-search');
+const {
+  closeScannerSetupDialog,
+  goToCreateCase,
+  goToReviewCase,
+  serveCaseToIrs,
+} = require('../support/pages/create-paper-case');
+const {
+  fillInCreateCaseFromPaperForm,
+} = require('../../cypress/support/pages/create-paper-petition');
+const { getUserToken, login } = require('../support/pages/login');
+const { goToCaseDetail } = require('../support/pages/case-detail');
+const { goToMyDocumentQC } = require('../support/pages/document-qc');
+
+const barNumberToSearchBy = 'PT1234';
+let testData = {};
+let token;
+
+describe('Create and serve a case to search for', () => {
+  before(async () => {
+    const results = await getUserToken(
+      'petitionsclerk1@example.com',
+      'Testing1234$',
+    );
+    token = results.AuthenticationResult.IdToken;
+  });
+
+  it('should be able to login', () => {
+    login(token);
+  });
+
+  it('should be able to create a case and serve to IRS', () => {
+    goToMyDocumentQC();
+    goToCreateCase();
+    closeScannerSetupDialog();
+    fillInCreateCaseFromPaperForm(testData);
+    goToReviewCase(testData);
+    serveCaseToIrs();
+  });
+});
+
+describe('Case Advanced Search', () => {
+  before(async () => {
+    const results = await getUserToken(
+      'docketclerk1@example.com',
+      'Testing1234$',
+    );
+    token = results.AuthenticationResult.IdToken;
+  });
+
+  it('should be able to login', () => {
+    login(token);
+  });
+
+  it('should be able to search for case by practitioner name', () => {
+    gotoAdvancedSearch();
+    searchByPetitionerName(testData.testPetitionerName);
+  });
+
+  it('should be able to search for case by docket number', () => {
+    gotoAdvancedSearch();
+    searchByDocketNumber(testData.createdPaperDocketNumber);
+  });
+});
+
+describe('Practitioner Search', () => {
+  before(async () => {
+    const results = await getUserToken(
+      'docketclerk1@example.com',
+      'Testing1234$',
+    );
+    token = results.AuthenticationResult.IdToken;
+  });
+
+  it('should be able to login', () => {
+    login(token);
+  });
+
+  it('should be able to search for a practitioner by name', () => {
+    gotoAdvancedPractitionerSearch();
+    searchByPractitionerName();
+  });
+
+  it('should be able to search for for a practitioner by bar number', () => {
+    gotoAdvancedPractitionerSearch();
+    searchByPractitionerbarNumber(barNumberToSearchBy);
+  });
+});
+
+describe('Opinion Search', () => {
+  before(async () => {
+    const results = await getUserToken(
+      'docketclerk1@example.com',
+      'Testing1234$',
+    );
+    token = results.AuthenticationResult.IdToken;
+  });
+
+  it('should be able to login', () => {
+    login(token);
+  });
+
+  it('should create an opinion to search for', () => {
+    goToCaseDetail(testData.createdPaperDocketNumber);
+    createOpinion();
+    addDocketEntryAndServeOpinion();
+  });
+
+  it('should be able to search for an opinion by keyword', () => {
+    goToOpinionSearch();
+    searchOpinionByKeyword('smoke test');
+  });
+});