From ba0f619b32e2999b379096aa815089ab7e4498f4 Mon Sep 17 00:00:00 2001 From: ElenaDiachenko Date: Fri, 13 Oct 2023 12:38:05 +0300 Subject: [PATCH 1/3] fix/macos_build_location_info --- packages/sdk-webpack/src/scripts/build.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/sdk-webpack/src/scripts/build.js b/packages/sdk-webpack/src/scripts/build.js index 969464901c..cf339eb86e 100644 --- a/packages/sdk-webpack/src/scripts/build.js +++ b/packages/sdk-webpack/src/scripts/build.js @@ -80,7 +80,8 @@ export default async () => ); logInfo(`To ignore, add ${chalk.cyan('// eslint-disable-next-line')} to the line before.\n`); } else { - logSuccess('Compiled successfully.\n'); + logSuccess(`Your Build is located in ${chalk.cyan(`./${process.env.RNV_APP_BUILD_DIR}`)} . \n`); + } logInfo('File sizes after gzip:\n'); @@ -182,7 +183,6 @@ function build(previousFileSizes) { .then(() => resolve(resolveArgs)) .catch((error) => reject(new Error(error))); } - return resolve(resolveArgs); }); }); From d2d98fd34879c47d56a7a801414f794cedce47a8 Mon Sep 17 00:00:00 2001 From: ElenaDiachenko Date: Fri, 13 Oct 2023 14:43:32 +0300 Subject: [PATCH 2/3] fix/export_log --- packages/engine-rn-electron/src/sdk.ts | 2 ++ packages/sdk-webpack/src/scripts/build.js | 7 ++----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/engine-rn-electron/src/sdk.ts b/packages/engine-rn-electron/src/sdk.ts index 1363e7a13b..a5c7c2472d 100644 --- a/packages/engine-rn-electron/src/sdk.ts +++ b/packages/engine-rn-electron/src/sdk.ts @@ -38,6 +38,7 @@ import { copyAssetsFolder, MACOS, LINUX, + TASK_EXPORT, } from '@rnv/core'; export const configureElectronProject = async (c: RnvContext, exitOnFail?: boolean) => { @@ -270,6 +271,7 @@ const buildElectron = async (c: RnvContext) => { const menuPathDest = path.join(platformBuildDir, 'build', 'contextMenu.js'); copyFileSync(menuPathSrc, menuPathDest); + if(c.command !== TASK_EXPORT)logSuccess(`Your Build is located in ${chalk().cyan(path.join(platformBuildDir, 'build'))} .`); return true; }; diff --git a/packages/sdk-webpack/src/scripts/build.js b/packages/sdk-webpack/src/scripts/build.js index cf339eb86e..5165eaae39 100644 --- a/packages/sdk-webpack/src/scripts/build.js +++ b/packages/sdk-webpack/src/scripts/build.js @@ -2,7 +2,7 @@ // Do this as the first thing so that any code reading it knows the right env. -import { logError, logInfo, logSuccess, logWarning } from '@rnv/core'; +import { logError, logInfo, logWarning} from '@rnv/core'; process.env.BABEL_ENV = 'production'; process.env.NODE_ENV = 'production'; @@ -79,10 +79,7 @@ export default async () => )} to learn more about each warning.` ); logInfo(`To ignore, add ${chalk.cyan('// eslint-disable-next-line')} to the line before.\n`); - } else { - logSuccess(`Your Build is located in ${chalk.cyan(`./${process.env.RNV_APP_BUILD_DIR}`)} . \n`); - - } + } logInfo('File sizes after gzip:\n'); printFileSizesAfterBuild( From c54039fa464d27e3951df1110a19d673989d9d3b Mon Sep 17 00:00:00 2001 From: Mihai Blaga Date: Mon, 16 Oct 2023 14:45:43 +0300 Subject: [PATCH 3/3] fixed linting --- packages/engine-rn-electron/src/sdk.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/engine-rn-electron/src/sdk.ts b/packages/engine-rn-electron/src/sdk.ts index a5c7c2472d..2e97b14230 100644 --- a/packages/engine-rn-electron/src/sdk.ts +++ b/packages/engine-rn-electron/src/sdk.ts @@ -271,7 +271,10 @@ const buildElectron = async (c: RnvContext) => { const menuPathDest = path.join(platformBuildDir, 'build', 'contextMenu.js'); copyFileSync(menuPathSrc, menuPathDest); - if(c.command !== TASK_EXPORT)logSuccess(`Your Build is located in ${chalk().cyan(path.join(platformBuildDir, 'build'))} .`); + if (c.command !== TASK_EXPORT) { + logSuccess(`Your Build is located in ${chalk().cyan(path.join(platformBuildDir, 'build'))} .`); + } + return true; };