From de879ef9b10adb1cb2bf709b062f8c14ce0b307d Mon Sep 17 00:00:00 2001
From: Dhruv  Sharma <dsharma@INRDEVSHARMAMB1.local>
Date: Fri, 9 Sep 2022 14:51:59 +0530
Subject: [PATCH 1/5] Pop up protection for confirming fully enable feature

---
 lib/flipper/ui/public/js/application.js | 11 +++++++++++
 lib/flipper/ui/views/feature.erb        |  2 +-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/lib/flipper/ui/public/js/application.js b/lib/flipper/ui/public/js/application.js
index 874be8666..3e2bbabe7 100644
--- a/lib/flipper/ui/public/js/application.js
+++ b/lib/flipper/ui/public/js/application.js
@@ -4,6 +4,17 @@ $(function () {
     return $container.toggleClass("toggle-on");
   });
 
+  $("#confirm-warn-enable").on("click", function (e) {
+    const featureName = $("#feature_name").val();
+    const promptMessage = prompt(
+      `Are you sure you want to Fully Enable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
+    );
+
+    if (promptMessage !== featureName) {
+      e.preventDefault();
+    }
+  });
+  
   $("#delete_feature__button").on("click", function (e) {
     const featureName = $("#feature_name").val();
     const promptMessage = prompt(
diff --git a/lib/flipper/ui/views/feature.erb b/lib/flipper/ui/views/feature.erb
index e8d207371..2fbdcb579 100644
--- a/lib/flipper/ui/views/feature.erb
+++ b/lib/flipper/ui/views/feature.erb
@@ -225,7 +225,7 @@
           <div class="row">
             <% unless @feature.boolean_value %>
              <div class="col">
-                <button type="submit" name="action" value="Enable" class="btn btn-outline-success btn-block">
+                <button type="submit" name="action" value="Enable" id="confirm-warn-enable" class="btn btn-outline-success btn-block">
                   <span class="d-block" data-toggle="tooltip" title="Enable for everyone">
                     Fully Enable
                   </span>

From f7c62dae19b85dc164cab328f6854ce67b39a492 Mon Sep 17 00:00:00 2001
From: Dhruv  Sharma <dsharma@INRDEVSHARMAMB1.local>
Date: Tue, 13 Sep 2022 18:59:10 +0530
Subject: [PATCH 2/5] Changed id as per review comment

---
 lib/flipper/ui/public/js/application.js | 2 +-
 lib/flipper/ui/views/feature.erb        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/flipper/ui/public/js/application.js b/lib/flipper/ui/public/js/application.js
index 3e2bbabe7..34440a5b0 100644
--- a/lib/flipper/ui/public/js/application.js
+++ b/lib/flipper/ui/public/js/application.js
@@ -4,7 +4,7 @@ $(function () {
     return $container.toggleClass("toggle-on");
   });
 
-  $("#confirm-warn-enable").on("click", function (e) {
+  $("#enable_feature__button").on("click", function (e) {
     const featureName = $("#feature_name").val();
     const promptMessage = prompt(
       `Are you sure you want to Fully Enable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
diff --git a/lib/flipper/ui/views/feature.erb b/lib/flipper/ui/views/feature.erb
index 2fbdcb579..6c12a5eb1 100644
--- a/lib/flipper/ui/views/feature.erb
+++ b/lib/flipper/ui/views/feature.erb
@@ -225,7 +225,7 @@
           <div class="row">
             <% unless @feature.boolean_value %>
              <div class="col">
-                <button type="submit" name="action" value="Enable" id="confirm-warn-enable" class="btn btn-outline-success btn-block">
+                <button type="submit" name="action" value="Enable" id="enable_feature__button" class="btn btn-outline-success btn-block">
                   <span class="d-block" data-toggle="tooltip" title="Enable for everyone">
                     Fully Enable
                   </span>

From a8524766189bdcfafa37013c73cf0857cebbeca4 Mon Sep 17 00:00:00 2001
From: Dhruv  Sharma <dsharma@INRDEVSHARMAMB1.local>
Date: Thu, 15 Sep 2022 14:40:41 +0530
Subject: [PATCH 3/5] Added configurtation option for Fully enable feature

---
 lib/flipper/ui/configuration.rb  |  5 +++++
 lib/flipper/ui/views/feature.erb | 24 +++++++++++++++++-------
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/lib/flipper/ui/configuration.rb b/lib/flipper/ui/configuration.rb
index f3db15a19..e09d12754 100644
--- a/lib/flipper/ui/configuration.rb
+++ b/lib/flipper/ui/configuration.rb
@@ -49,6 +49,10 @@ class Configuration
       # Default is comma ",".
       attr_accessor :actors_separator
 
+      # Public: if you want to get a confirm pop up box while fully enabling a feature
+      # Default is False
+      attr_accessor :confirm_fully_enable
+
       VALID_BANNER_CLASS_VALUES = %w(
         danger
         dark
@@ -74,6 +78,7 @@ def initialize
         @descriptions_source = DEFAULT_DESCRIPTIONS_SOURCE
         @show_feature_description_in_list = false
         @actors_separator = ','
+        @confirm_fully_enable = false
       end
 
       def using_descriptions?
diff --git a/lib/flipper/ui/views/feature.erb b/lib/flipper/ui/views/feature.erb
index 6c12a5eb1..e405fb0b8 100644
--- a/lib/flipper/ui/views/feature.erb
+++ b/lib/flipper/ui/views/feature.erb
@@ -224,13 +224,23 @@
 
           <div class="row">
             <% unless @feature.boolean_value %>
-             <div class="col">
-                <button type="submit" name="action" value="Enable" id="enable_feature__button" class="btn btn-outline-success btn-block">
-                  <span class="d-block" data-toggle="tooltip" title="Enable for everyone">
-                    Fully Enable
-                  </span>
-                </button>
-              </div>
+              <% if Flipper::UI.configuration.confirm_fully_enable %>
+                <div class="col">
+                  <button type="submit" name="action" value="Enable" id="enable_feature__button" class="btn btn-outline-success btn-block">
+                    <span class="d-block" data-toggle="tooltip" title="Enable for everyone">
+                      Fully Enable
+                    </span>
+                  </button>
+                </div>
+              <% else %>
+                <div class="col">
+                  <button type="submit" name="action" value="Enable" class="btn btn-outline-success btn-block">
+                    <span class="d-block" data-toggle="tooltip" title="Enable for everyone">
+                      Fully Enable
+                    </span>
+                  </button>
+                </div>
+              <% end %>
             <% end %>
 
             <% unless @feature.off? %>

From 8d13c7c7d4739b7d629f611e276d7759fdd972da Mon Sep 17 00:00:00 2001
From: John Nunemaker <nunemaker@hey.com>
Date: Wed, 28 Sep 2022 10:37:52 -0400
Subject: [PATCH 4/5] Update lib/flipper/ui/configuration.rb

---
 lib/flipper/ui/configuration.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/flipper/ui/configuration.rb b/lib/flipper/ui/configuration.rb
index e09d12754..d2476c093 100644
--- a/lib/flipper/ui/configuration.rb
+++ b/lib/flipper/ui/configuration.rb
@@ -50,7 +50,7 @@ class Configuration
       attr_accessor :actors_separator
 
       # Public: if you want to get a confirm pop up box while fully enabling a feature
-      # Default is False
+      # Default is false.
       attr_accessor :confirm_fully_enable
 
       VALID_BANNER_CLASS_VALUES = %w(

From 1a75cd6b79522bd2aa7e6ad916cc640dc418a1e6 Mon Sep 17 00:00:00 2001
From: John Nunemaker <nunemaker@hey.com>
Date: Wed, 28 Sep 2022 10:38:27 -0400
Subject: [PATCH 5/5] Update lib/flipper/ui/public/js/application.js

---
 lib/flipper/ui/public/js/application.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/flipper/ui/public/js/application.js b/lib/flipper/ui/public/js/application.js
index 34440a5b0..c62e5a5c1 100644
--- a/lib/flipper/ui/public/js/application.js
+++ b/lib/flipper/ui/public/js/application.js
@@ -7,7 +7,7 @@ $(function () {
   $("#enable_feature__button").on("click", function (e) {
     const featureName = $("#feature_name").val();
     const promptMessage = prompt(
-      `Are you sure you want to Fully Enable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
+      `Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
     );
 
     if (promptMessage !== featureName) {