Multi-pass processing #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
added
enhancement
BenBE
force-pushed
the
multipass
branch
2 times, most recently
from
e886c55
to
b363e1f
Compare
phlash
reviewed
Mar 4, 2022
|
Do we want to consider parallel processing the multiple passes? IMO this is probably not worth the extra pain unless we run very low on time budget.. |
I'll do this as one process in the first version. We can still upgrade to multi-threading this processing in a second update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will introduce multi-pass processing of the input image for cases when the internal face detection model cannot handle the full input image in one go due to the aspect ratio of the model compared to the aspect ratio of the input image.
This PR also contains a major cleanup of the code base by making the code style more consistent and splitting things into multiple files for more digestible chunks of code.