[FLORA-414] Store archive hashes #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
force-pushed
the
store-archive-hashes
branch
from
5eb0c64
to
b7bfa48
Compare
tchoutri
force-pushed
the
store-archive-hashes
branch
from
b7bfa48
to
38d4e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The astute reader will notice that an IORef is used. It is because when we read the tarball, we encounter the JSON file of a release before the cabal file. As such, the release is not yet present in the database, so we store it in memory until we encounter the cabal file. Then we collect the hash and delete it from the in-memory map.
Contributor checklist