Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with Infinity and NaN when translating values #223

Closed
EagleoutIce opened this issue Aug 23, 2023 · 0 comments · Fixed by #692
Closed

Deal with Infinity and NaN when translating values #223

EagleoutIce opened this issue Aug 23, 2023 · 0 comments · Fixed by #692
Labels
enhancement New feature or request R Requires R Code/Interaction with the R programming language from the TypeScript side

Comments

@EagleoutIce
Copy link
Member

Currently our conversion functions ts2r and number2ts do not handle NaN or Infinity correctly. We should change that.

https://github.com/Code-Inspect/flowr/blob/438a6058af160ec0999b635a5649ef774c610c86/src/r-bridge/lang-4.x/values.ts#L10-L13
@EagleoutIce EagleoutIce added enhancement New feature or request R Requires R Code/Interaction with the R programming language from the TypeScript side labels Aug 23, 2023
@bjthehun bjthehun mentioned this issue Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request R Requires R Code/Interaction with the R programming language from the TypeScript side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat-fix: handle Infinity, NaN in value conversion bjthehun/flowr
1 participant
@EagleoutIce