Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Environment Fingerprinting #763

Closed
EagleoutIce opened this issue May 5, 2024 · 2 comments · Fixed by #782
Closed

Speed up Environment Fingerprinting #763

EagleoutIce opened this issue May 5, 2024 · 2 comments · Fixed by #782
Assignees
@EagleoutIce
Labels
enhancement New feature or request static slicing Related to slicing the source code statically

Comments

@EagleoutIce
Copy link
Member

When calculating an environment-fingerprint during slicing, we should speed this up by reusing previously calculated hashes for the root environment/shared environments.
We can, for example, re-use the id of the environment to speed up fingerprint retrieval.
@EagleoutIce EagleoutIce added enhancement New feature or request static slicing Related to slicing the source code statically labels May 5, 2024
@EagleoutIce
Copy link
Member Author

Furthermore, environments do not need names!

@EagleoutIce
Copy link
Member Author

Maybe we can just use the replacer to ignore the built-in environment on every fingerprint

@EagleoutIce EagleoutIce assigned EagleoutIce and unassigned Ellpeck May 10, 2024
@EagleoutIce EagleoutIce linked a pull request May 10, 2024 that will close this issue
Omit the built-in-environment on env-fingerprinting #782
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EagleoutIce EagleoutIce

Labels
enhancement New feature or request static slicing Related to slicing the source code statically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit the built-in-environment on env-fingerprinting flowr-analysis/flowr
2 participants
@Ellpeck @EagleoutIce