Add a mechanism for communicating streaming size behaviour at compile… #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weefuzzy - I've included you here because there are some things to review (or tell us that you don't wish to review) in the max wrapper change coming up and that involves being aware of this change. |
weefuzzy
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… time
This is part of a fix for the max (and other) wrappers that is needed so that wrappers can be aware of how IO sizes will be managed at compile time (and consequently without the need to instantiate a client - as in the main() of the max wrapper or the equivalent class definition section of the pd wrapper).
As this involves hierarchical inheritance this change should not affect the current behaviour of the wrappers in any way until modifications are made to them also.