Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Jul 17, 2024

No description provided.

@kmd-fl kmd-fl requested a review from folex July 17, 2024 15:00
on HOST_PEER_ID:
try:
try:
on HOST_PEER_ID:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that need to be executed on host and not on worker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because aqua-ipfs is available only on host.

Copy link
Contributor

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make log functions independent of the call side, and always route to worker_id. Maybe we'll be able to do that with aquaduct.

@alari wdyt?

@kmd-fl kmd-fl added the e2e Run e2e workflow label Jul 18, 2024
@kmd-fl kmd-fl enabled auto-merge (squash) July 22, 2024 10:38
@kmd-fl
Copy link
Contributor Author

kmd-fl commented Jul 25, 2024

IS CI doesn't work because of the changes in the nox: now only managers can create workers outside, but we create new workers in each test. I don't see a good way to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

e2e Run e2e workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants