-
Notifications
You must be signed in to change notification settings - Fork 0
fix(installation-spell): print logs on a service #291
base: main
Are you sure you want to change the base?
Conversation
| on HOST_PEER_ID: | ||
| try: | ||
| try: | ||
| on HOST_PEER_ID: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that need to be executed on host and not on worker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because aqua-ipfs is available only on host.
folex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make log functions independent of the call side, and always route to worker_id. Maybe we'll be able to do that with aquaduct.
@alari wdyt?
|
IS CI doesn't work because of the changes in the nox: now only managers can create workers outside, but we create new workers in each test. I don't see a good way to fix this. |
No description provided.