Winevtlog does not include DST in UTC offset#8385
Closed
laurensknoll wants to merge 2 commits intofluent:masterfrom
Closed
Winevtlog does not include DST in UTC offset#8385laurensknoll wants to merge 2 commits intofluent:masterfrom
laurensknoll wants to merge 2 commits intofluent:masterfrom
Conversation
laurensknoll
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Author
|
Fixed commit messages in secondary branch. New PR: #8386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the local times emitted by the
winevtloginput plugin include daylight savings time. Daylight savings time is respected as in thewindows-exporter-metricsinput plugin ref.The issue arises when the Windows event log entry time (UTC) is converted into a local time, and becomes apparent after forwarding the event to Stackdriver (Google Cloud Logging):
winevtloginput plugin outputs the value as local timeThe time is displayed in local time (Sydney time zone, UTC +10:00), but does not include DST. The expected offset is +1100.
{ "TimeCreated"=>"2024-01-16 02:48:24 +1000" }stackdriverThe event time is outputted as
timestampref in UTC.{ "jsonPayload": { "TimeCreated": "2024-01-16 02:48:24 +1000" }, "timestamp": "2024-01-15T15:48:24Z", "receiveTimestamp": "2024-01-15T14:48:26.45698121Z", }The issue becomes apparent when Google Cloud Logging, on receive, adds a
receiveTimestamp. This timestamp indicates that the event is from the future, because the UTC offset was not correct (+1000 instead of +1100 due to daylight savings time).Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
This change does not add any new features to the Fluent Bit binary.
See below.
Valgrind does not run on Windows. Any recommendations on running Valgrind otherwise?
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).This change does not touch the packaging.
Documentation
The documentation does not mention UTC to local time conversion.
Backporting
Unsure. Google Cloud Logging accepts entries up to 24 hours in the future. Impact on other outputs is not clear.
Debug output
Debug output from non-fixed build:
Debug output from fixed build:
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.