Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-linter package is broken #1055

Closed
jpverde opened this issue Mar 17, 2023 · 2 comments
Closed

nix-linter package is broken #1055

jpverde opened this issue Mar 17, 2023 · 2 comments

Comments

@jpverde
Copy link
Collaborator

jpverde commented Mar 17, 2023 •
edited
Loading

nix-linter package is marked as broken in nixpkgs making lintNix broken.
This package is also not being actively maintained, lets consider changing it to a modern linter like statix
jpverde added a commit to jpverde/makes that referenced this issue Mar 17, 2023
@jpverde
refac(doc): fluidattacks#1055 use statix
c2ffe23 
- Use `statix` as the `lintNix` main package
- Fix warnings from the linter

Signed-off-by: John Perez <mrjohnjairo10@gmail.com>
jpverde added a commit to jpverde/makes that referenced this issue Mar 17, 2023
@jpverde
refac(doc): fluidattacks#1055 use statix
bc4224e 
- Use `statix` as the `lintNix` main package
- Fix warnings from the linter

Signed-off-by: John Perez <mrjohnjairo10@gmail.com>
jpverde added a commit that referenced this issue Mar 17, 2023
@jpverde
Merge pull request #1056 from jpverde/main
d624cd9 
refac(doc): #1055 use statix
@dsalaza4
Copy link
Contributor

  • Automatically fix before failing
  • Separate arg from module
  • Update doc

jpverde added a commit to jpverde/makes that referenced this issue Mar 30, 2023
@jpverde
refac(back): fluidattacks#1055 update lintnix
73311c3 
- Separate arg from module
- Make `lintNix` to fix files and fail if it has errors

Signed-off-by: John Perez <mrjohnjairo10@gmail.com>
jpverde added a commit to jpverde/makes that referenced this issue Mar 30, 2023
@jpverde
refac(back): fluidattacks#1055 update lintnix
ec6f0ac 
- Separate arg from module
- Make `lintNix` to fix files and fail if it has errors

Signed-off-by: John Perez <mrjohnjairo10@gmail.com>
jpverde added a commit to jpverde/makes that referenced this issue Mar 30, 2023
@jpverde
refac(back): fluidattacks#1055 update lintnix
cddef8f 
- Separate arg from module
- Make `lintNix` to fix files and fail if it has errors
- Update docs

Signed-off-by: John Perez <mrjohnjairo10@gmail.com>
dsalaza4 added a commit that referenced this issue Mar 30, 2023
@dsalaza4
Merge pull request #1063 from jpverde/main
c6c19e4 
refac(back): #1055 update lintnix
@jpverde
Copy link
Collaborator Author

jpverde commented Mar 30, 2023

I think this is done.

@jpverde jpverde closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsalaza4 @jpverde