Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projectPath can't start with a dot #1200

Closed
dacevedo12 opened this issue Dec 4, 2023 · 1 comment
Closed

projectPath can't start with a dot #1200

dacevedo12 opened this issue Dec 4, 2023 · 1 comment
Assignees
@dsalaza4

Comments

@dacevedo12
Copy link
Collaborator

dacevedo12 commented Dec 4, 2023 •
edited
Loading

Since nix 2.19.0 store paths are not allowed to start with a dot.

image

NixOS/nix#9095

perhaps it could be escaped in the projectPath arg to avoid running into this error
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 4, 2023
@dsalaza4
feat(back): fluidattacks#1200 support hidden files in root
e06f597 
- Add support for hidden files in root when using projectPath
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 4, 2023
@dsalaza4
feat(back): fluidattacks#1200 support hidden files in root
69828c7 
- Add support for hidden files in root when using projectPath
- Adapt lintPython to support new directory names
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 4, 2023
@dsalaza4
feat(back): fluidattacks#1200 support hidden files in root
5952293 
- Add support for hidden files in root when using projectPath
- Adapt lintPython to support new directory names

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit that referenced this issue Dec 4, 2023
@dsalaza4
Merge pull request #1201 from dsalaza4/main
31455b0 
feat(back): #1200 support hidden files in root
@dsalaza4 dsalaza4 closed this as completed Dec 4, 2023
@dsalaza4 dsalaza4 self-assigned this Dec 4, 2023
@dsalaza4 dsalaza4 reopened this Dec 5, 2023
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 5, 2023
@dsalaza4
fix(back): fluidattacks#1200 module name
1040383 
- Use last directory in path as module name
in order to avoid breaking the builtin

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit that referenced this issue Dec 5, 2023
@dsalaza4
Merge pull request #1203 from dsalaza4/main
946c7ae 
fix(back): #1200 module name
@dsalaza4 dsalaza4 closed this as completed Dec 5, 2023
@dsalaza4 dsalaza4 reopened this Dec 5, 2023
@dsalaza4
Copy link
Contributor

dsalaza4 commented Dec 5, 2023 •
edited
Loading

Still having issues. Decided to keep basenames and remove . prefixes.

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 5, 2023
@dsalaza4
refac(back): fluidattacks#1200 remove prefix
dda5da5 
- Keep using basename in order to avoid errors
- Remove prefix dot if basename contains it
- get package_name the old way

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit that referenced this issue Dec 5, 2023
@dsalaza4
Merge pull request #1205 from dsalaza4/main
9b7cd3a 
refac(back): #1200 remove prefix
@dsalaza4 dsalaza4 closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsalaza4 dsalaza4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsalaza4 @dacevedo12