Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): #990 move cache directory #1116

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

sebas031811
Copy link
Contributor

No description provided.

@dsalaza4
Copy link
Contributor

Hi @sebas031811,

Thank you so much for your contribution!

I see other files that also reference the .makes folder:

global = "$HOME_IMPURE/.makes/state";
project = "$HOME_IMPURE/.makes/state/__default__";

default = "$HOME_IMPURE/.makes/state";

@sebas031811
Copy link
Contributor Author

Hi @dsalaza4,
I understood it was just '.makes/cache'. Anyway, there is also a file 'demo.svg', how could I change it?

@dsalaza4
Copy link
Contributor

@sebas031811 Everything should be under .cache/makes now.

Regarding the demo, you can leave it the way it is.

src/args/agnostic.nix Outdated Show resolved Hide resolved
docs/src/api/extensions/fundamentals.md Outdated Show resolved Hide resolved
docs/src/api/extensions/fundamentals.md Outdated Show resolved Hide resolved
src/cli/main/cli.py Outdated Show resolved Hide resolved
src/cli/main/cli.py Outdated Show resolved Hide resolved
src/cli/main/cli.py Outdated Show resolved Hide resolved
src/evaluator/modules/default.nix Outdated Show resolved Hide resolved
@sebas031811 sebas031811 force-pushed the sebas031811 branch 2 times, most recently from 2bc7368 to 701fbaf Compare June 26, 2023 23:42
@dsalaza4
Copy link
Contributor

Please resolve previous threads accordingly

Signed-off-by: Sebastian Cardona <sebas03181@gmail.com>
@dsalaza4
Copy link
Contributor

dsalaza4 commented Jun 27, 2023

@sebas031811

Calling the TUI with m . and then runing a job seems to be failing after installing your CLI version with nix-env -if ..

To reproduce:

  1. Install your cli with nix-env -if .
  2. Run any makes job from the TUI by running m . first and then selecting a job.

@dsalaza4
Copy link
Contributor

dsalaza4 commented Jun 27, 2023

@sebas031811

Calling the TUI with m . and then selection a job seems to be failing after installing your CLI version with nix-env -if ..

To reproduce:

  1. Install your cli with nix-env -if .
  2. Run any makes job from the TUI by running m . first and then selecting a job.

I think it has to do with having an unnecessary second level cache directory here:

cache = join(MAKES_DIR, "cache", "last.json")

Maybe just join(MAKES_DIR, "last.json") ?

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@dsalaza4 dsalaza4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsalaza4 dsalaza4 merged commit 4340e83 into fluidattacks:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants