Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): #1099 fix testlicense bug #1117

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

rohaquinlop
Copy link
Collaborator

  • fix testLicense still appears when there are no references.

- fix `testlicense` still appears when there is no references.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rohaquinlop
Copy link
Collaborator Author

@dsalaza4 I don't get it why some checks are failing. Are these checks failing because of my commit?

@dsalaza4
Copy link
Contributor

dsalaza4 commented Jul 4, 2023

@dsalaza4 I don't get it why some checks are failing. Are these checks failing because of my commit?

It is not because of your commit.

It looks like mac checks are failing.

Copy link
Contributor

@dsalaza4 dsalaza4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsalaza4 dsalaza4 merged commit 91ee9fe into fluidattacks:main Jul 4, 2023
@rohaquinlop rohaquinlop deleted the fix-bug-testLicense branch August 31, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants