Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple maps support #315

Merged

Conversation

andrea689
Copy link
Collaborator

this PR resolve #295, and fix a bug when more than one map are used in Android or iOS too.

I also fix ScrollingMapPage to add symbols only on onStyleLoadedCallback

fix ScrollingMapPage example
Copy link
Collaborator

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Nick Ray and others added 6 commits June 8, 2020 19:31
It looks like this invokation was accidentally removed in
ebef5db which prevents the firing of
`onCameraIdle` (if the client passes this option). This commit adds this
functionality back in.
Before this commit, passing the `zIndex` SymbolOption would be inert as
the android implementation thought this option was called
'symbolSortKey'. This commit corrects that so that the Android zIndex
implementation works again.
* Try to load a style from a local asset if styleString does not start with http(s):// or mapbox://

* Add style.json asset for testing.

* Update map_ui so that we can toggle through different map styles.

* Added similar implementation on Android for parity.

* Added some documentation on the usage of map styles.
fix ScrollingMapPage example
…ter-mapbox-gl into av-multiple-map-instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor web MapboxMapController implementation to allow multiple maps in the same page
3 participants