Add window channel

[HakkyuKim]

The use case for setting window geometry at runtime is explained here (internal repo).

Test app: https://github.com/HakkyuKim/flutter_tizen_window_resize_test_app

TODO

• Disable for evas_gl renderer.
• Investigate why it works for TV and wearable emulators but not for mobile.
  Can't figure out why, decided not to support in this PR since it's not important compared to other tasks.
• Investigate why x and y position are not set correctly.
  Must also call ecore_wl2_window_position_set.
• Test with rotation.
  I'll write a "remaining issues" in the issue tab.
• Test with top_level window, Support top-layer mode #191.
• Formatting.
• Check dynamic type of TizenRenderer in WindowChannel::HandleMethodCall(). Use conditional compilation.

[HakkyuKim]

Resizing the window for evas_gl is not displaying the same as ecore_wl2 and I can't figure out why. The engines used in the following images are compiled using the same logic with different TizenRenderer:

Wearable

TizenRendererEcoreWl2

TizenRendererEvasGL

TV

TizenRendererEcoreWl2

TizenRendererEvasGL

@bbrto21 @xiaowei-guan Would you happen to have any information on this?

[bwikbs]

Just curious... why did you disable at x64? (Is this for evas issue? Same result on x64?)
I think it would be good to include a unit test..

[HakkyuKim]

Just curious... why did you disable at x64? (Is this for evas issue? Same result on x64?) I think it would be good to include a unit test..

My understanding was that you could only test apis that are purely EFL on x64, the current implementation calls tizen only apis; ecore_wl2_window_position_set and ecore_wl2_egl_window_resize_with_rotation. Or am I mistaken?

[swift-kim]

Otherwise looks good to me!

[HakkyuKim]

Otherwise looks good to me!

Done! Thanks for the review:)

[bwikbs]

My understanding was that you could only test apis that are purely EFL on x64, the current implementation calls tizen only apis; ecore_wl2_window_position_set and ecore_wl2_egl_window_resize_with_rotation. Or am I mistaken?

First , it's not really important. I just asked....
I think I changed the window geometry in x64 before.. and we could only test the window channel operation (Not real behavior!) at unit test.. I just wondered why it was blocked at this time. Now I understand through your response.

Thanks! It's pretty cool! 👍

[bbrto21]

@bbrto21 @xiaowei-guan Would you happen to have any information on this?

I'm working on another task, so I can't afford to look into this. Sorry for the late reply.

[HakkyuKim]

My understanding was that you could only test apis that are purely EFL on x64, the current implementation calls tizen only apis; ecore_wl2_window_position_set and ecore_wl2_egl_window_resize_with_rotation. Or am I mistaken?

First , it's not really important. I just asked.... I think I changed the window geometry in x64 before.. and we could only test the window channel operation (Not real behavior!) at unit test.. I just wondered why it was blocked at this time. Now I understand through your response.

Thanks! It's pretty cool! +1

I was double checking if I was correct about the __X64_SHELL__ define, I appreciate the review. I haven't planned adding unit test at the moment, maybe some other time.

[swift-kim]

Please resolve conflicts.

[HakkyuKim]

Please resolve conflicts.

Done, merging would've been better, the conflict was:

-event.width = static_cast<size_t>(width);
-event.height = static_cast<size_t>(height);
+event.width = width;
+event.height = height;