From 6bb65140b49f5901516e6e928b61c19f73cb7afb Mon Sep 17 00:00:00 2001 From: Xiaowei Guan Date: Mon, 25 Nov 2024 14:01:27 +0800 Subject: [PATCH 1/3] Make startPosition support int32_t --- packages/video_player_avplay/tizen/src/plus_player.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/video_player_avplay/tizen/src/plus_player.cc b/packages/video_player_avplay/tizen/src/plus_player.cc index 6b90e125a..ea1be8b2e 100644 --- a/packages/video_player_avplay/tizen/src/plus_player.cc +++ b/packages/video_player_avplay/tizen/src/plus_player.cc @@ -139,6 +139,10 @@ int64_t PlusPlayer::Create(const std::string &uri, int64_t start_position = flutter_common::GetValue( create_message.player_options(), "startPosition", (int64_t)0); + if (start_position == 0) { + start_position = flutter_common::GetValue(create_message.player_options(), + "startPosition", (int32_t)0); + } if (start_position > 0) { LOG_INFO("[PlusPlayer] Start position: %lld", start_position); if (!Seek(player_, start_position)) { From 1063348f1eec427f708988ea2ff19addfc98845a Mon Sep 17 00:00:00 2001 From: Xiaowei Guan Date: Mon, 25 Nov 2024 14:08:29 +0800 Subject: [PATCH 2/3] Version up --- packages/video_player_avplay/CHANGELOG.md | 4 ++++ packages/video_player_avplay/README.md | 2 +- packages/video_player_avplay/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/video_player_avplay/CHANGELOG.md b/packages/video_player_avplay/CHANGELOG.md index 8854d3a75..c6eb43d47 100644 --- a/packages/video_player_avplay/CHANGELOG.md +++ b/packages/video_player_avplay/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.6 + +* Make startPosition support int32_t type. + ## 0.5.5 * Fix select audio channel failed issue. diff --git a/packages/video_player_avplay/README.md b/packages/video_player_avplay/README.md index e772bd73c..f676f1f38 100644 --- a/packages/video_player_avplay/README.md +++ b/packages/video_player_avplay/README.md @@ -12,7 +12,7 @@ To use this package, add `video_player_avplay` as a dependency in your `pubspec. ```yaml dependencies: - video_player_avplay: ^0.5.5 + video_player_avplay: ^0.5.6 ``` Then you can import `video_player_avplay` in your Dart code: diff --git a/packages/video_player_avplay/pubspec.yaml b/packages/video_player_avplay/pubspec.yaml index d8f221bc0..54d64c609 100644 --- a/packages/video_player_avplay/pubspec.yaml +++ b/packages/video_player_avplay/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player_avplay description: Flutter plugin for displaying inline video on Tizen TV devices. homepage: https://github.com/flutter-tizen/plugins repository: https://github.com/flutter-tizen/plugins/tree/master/packages/video_player_avplay -version: 0.5.5 +version: 0.5.6 environment: sdk: ">=3.1.0 <4.0.0" From d68e0b12c796c535433e8c27b311eeca4e527d3d Mon Sep 17 00:00:00 2001 From: Xiaowei Guan Date: Thu, 28 Nov 2024 09:14:20 +0800 Subject: [PATCH 3/3] Add TODO for start position --- packages/video_player_avplay/tizen/src/plus_player.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/video_player_avplay/tizen/src/plus_player.cc b/packages/video_player_avplay/tizen/src/plus_player.cc index ea1be8b2e..90ed622bf 100644 --- a/packages/video_player_avplay/tizen/src/plus_player.cc +++ b/packages/video_player_avplay/tizen/src/plus_player.cc @@ -140,6 +140,10 @@ int64_t PlusPlayer::Create(const std::string &uri, int64_t start_position = flutter_common::GetValue( create_message.player_options(), "startPosition", (int64_t)0); if (start_position == 0) { + // if startPosition is in the range of int32_t, it will convert as int32_t. + // if startPosition >= INT32_MAX, it will convert as int64_t. + // TODO we will implement a new function for long type, no need call two + // times. start_position = flutter_common::GetValue(create_message.player_options(), "startPosition", (int32_t)0); }