Skip to content

Add test exemption for embedder tests and fixtures #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add test exemption for embedder tests and fixtures #2340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app_dart/lib/src/request_handlers/github/webhook_subscription.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,9 @@ class GithubWebhookSubscription extends SubscriptionHandler {
filename.contains('.github/') ||
filename.endsWith('.md') ||
// Exempt paths.
filename.startsWith('dev/devicelab/lib/versions/gallery.dart');
filename.startsWith('dev/devicelab/lib/versions/gallery.dart') ||
filename.startsWith('shell/platform/embedder/tests') ||
filename.startsWith('shell/platform/embedder/fixtures');
}

/// Returns the set of labels applicable to a file in the framework repo.
Expand Down
6 changes: 4 additions & 2 deletions app_dart/test/request_handlers/github/webhook_subscription_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,9 +889,11 @@ void main() {
final RepositorySlug slug = RepositorySlug('flutter', 'flutter');

when(pullRequestsService.listFiles(slug, issueNumber)).thenAnswer(
(_) => Stream<PullRequestFile>.value(
(_) => Stream<PullRequestFile>.fromIterable(<PullRequestFile>[
PullRequestFile()..filename = 'dev/devicelab/lib/versions/gallery.dart',
),
PullRequestFile()..filename = 'shell/platform/embedder/tests/embedder_test_context.cc',
PullRequestFile()..filename = 'shell/platform/embedder/fixtures/main.dart',
]),
);

when(issuesService.listCommentsByIssue(slug, issueNumber)).thenAnswer(
Expand Down