From 25a398223891533857ae9ba7d9ad9b7e47410b0b Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 9 Apr 2025 15:57:16 -0700 Subject: [PATCH 1/3] Prevent web apps from freezing on hot-restart --- .../lib/src/screens/debugger/breakpoint_manager.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart b/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart index a18c39d24b2..35ec6de4c7e 100644 --- a/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart +++ b/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart @@ -93,6 +93,10 @@ class BreakpointManager with DisposerMixin { if ([ EventKind.kPauseStart, EventKind.kPausePostRequest, + // We check for a resume event because package:dwds sends a resume event + // after a hot-restart. See: + // https://github.com/flutter/devtools/issues/9124 + EventKind.kResume, ].contains(pauseEventKind)) { await serviceConnection.serviceManager.isolateManager.resumeIsolate( isolateRef, From 74b7ab1210351ddefb79c865d03365cf4dee781f Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 11 Apr 2025 14:45:27 -0700 Subject: [PATCH 2/3] Update release notes --- packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md index 9c55b86fedf..aae3a2f89c1 100644 --- a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md +++ b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md @@ -15,7 +15,8 @@ To learn more about DevTools, check out the ## General updates -TODO: Remove this section if there are not any general updates. +- Prevent web apps from remaining paused after triggering a hot-restart from +DevTools. - [#9125](https://github.com/flutter/devtools/pull/9125) ## Inspector updates From 17069a0abd78c8a5f31ce1fc9712d2f1d385b224 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 14 Apr 2025 13:07:14 -0700 Subject: [PATCH 3/3] Update issue reference --- .../lib/src/screens/debugger/breakpoint_manager.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart b/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart index 35ec6de4c7e..89e887d99b6 100644 --- a/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart +++ b/packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart @@ -95,7 +95,7 @@ class BreakpointManager with DisposerMixin { EventKind.kPausePostRequest, // We check for a resume event because package:dwds sends a resume event // after a hot-restart. See: - // https://github.com/flutter/devtools/issues/9124 + // https://github.com/dart-lang/webdev/issues/2610 EventKind.kResume, ].contains(pauseEventKind)) { await serviceConnection.serviceManager.isolateManager.resumeIsolate(