When cloning YieldStatement, copy the flags

Kevin Millikin · commit-bot@chromium.org · commit 0a4a3bed683d · 2018-04-10T08:47:40.000Z
Cloning a YieldStatement should not lose the value of the flags. Fixes dart-lang/sdk#32466 Change-Id: I084a81882fdc404184c343cbf477ce8e9a1d521e Reviewed-on: https://dart-review.googlesource.com/50400 Reviewed-by: Jens Johansen <jensj@google.com> Commit-Queue: Kevin Millikin <kmillikin@google.com>
diff --git a/pkg/kernel/lib/clone.dart b/pkg/kernel/lib/clone.dart
@@ -392,7 +392,7 @@ class CloneVisitor implements TreeVisitor {
   }
 
   visitYieldStatement(YieldStatement node) {
-    return new YieldStatement(clone(node.expression));
+    return new YieldStatement(clone(node.expression))..flags = node.flags;
   }
 
   visitVariableDeclaration(VariableDeclaration node) {

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ class CloneVisitor implements TreeVisitor {`
`392`	`392`	`}`
`393`	`393`
`394`	`394`	`visitYieldStatement(YieldStatement node) {`
`395`		`- return new YieldStatement(clone(node.expression));`
	`395`	`+ return new YieldStatement(clone(node.expression))..flags = node.flags;`
`396`	`396`	`}`
`397`	`397`
`398`	`398`	`visitVariableDeclaration(VariableDeclaration node) {`