Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5a2ccef

Browse files
authored
Forward fix for roll of Dart SDK to version with new checked-in SDK (#41634)
The checked-in SDK downloaded by Dart and engine checkouts from cipd has changed. The cipd package no longer includes dart-sdk at the start of all the paths of its files, so /dart-sdk is added to the path of the cipd download location. The script that automatically copies DEPS changes from the Dart SDK to engine does not handle the download location changing, and drops that entry. This change copies the changed download location and cipd reference from Dart SDK DEPS to engine. A roll of the Dart SDK to a version that does not include this update will fail by removing the changed line, so the next successful roll after this is landed must include Dart SDK commit 88aeaa4fec387ce6993b0bfe54d0d33c41d4554a. Link to the Dart SDK commit is https://dart.googlesource.com/sdk.git/+/88aeaa4fec387ce6993b0bfe54d0d33c41d4554a
1 parent a37bd4b commit 5a2ccef

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

DEPS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,8 +497,8 @@ deps = {
497497
'src/third_party/dart/third_party/pkg/yaml_edit':
498498
Var('dart_git') + '/yaml_edit.git' + '@' + Var('dart_yaml_edit_rev'),
499499

500-
'src/third_party/dart/tools/sdks':
501-
{'packages': [{'version': 'version:3.0.0-417.2.beta', 'package': 'dart/dart-sdk/${{platform}}'}], 'dep_type': 'cipd'},
500+
'src/third_party/dart/tools/sdks/dart-sdk':
501+
{'packages': [{'version': 'git_revision:d2b8bf9c2ec1bd479dfd255ae70a62aa723df931', 'package': 'dart/dart-sdk/${{platform}}'}], 'dep_type': 'cipd'},
502502

503503
# WARNING: end of dart dependencies list that is cleaned up automatically - see create_updated_flutter_deps.py.
504504

0 commit comments

Comments
 (0)