From 6e14fd429277918b7f812550df00ce25bd7323b4 Mon Sep 17 00:00:00 2001 From: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Date: Tue, 26 Sep 2023 11:38:43 -0700 Subject: [PATCH] Clean up the docstring for ColorFilter.matrix (#46298) The first line is important since it is pulled out into https://api.flutter.dev/flutter/dart-ui/ColorFilter-class.html. The existing wording is very confusing about what the input actually is. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- lib/ui/painting.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ui/painting.dart b/lib/ui/painting.dart index ea6fa78fa88ff..6784474e88a31 100644 --- a/lib/ui/painting.dart +++ b/lib/ui/painting.dart @@ -3482,8 +3482,9 @@ class ColorFilter implements ImageFilter { _matrix = null, _type = _kTypeMode; - /// Construct a color filter that transforms a color by a 5x5 matrix, where - /// the fifth row is implicitly added in an identity configuration. + /// Construct a color filter from a 4x5 row-major matrix. The matrix is + /// interpreted as a 5x5 matrix, where the fifth row is the identity + /// configuration. /// /// Every pixel's color value, represented as an `[R, G, B, A]`, is matrix /// multiplied to create a new color: