From 746c7a1cc49e0351bc88bb8ec4803bfb853c70c5 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Wed, 4 Sep 2019 07:58:52 -0700 Subject: [PATCH] Add a sample unit test target to flutter runner (#11847) --- DEPS | 2 +- ci/licenses_golden/licenses_flutter | 1 + shell/platform/fuchsia/flutter/BUILD.gn | 37 +++++++++++++++++++ .../fuchsia/flutter/sample_unittests.cc | 15 ++++++++ 4 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 shell/platform/fuchsia/flutter/sample_unittests.cc diff --git a/DEPS b/DEPS index dd41dab7092a6..37cd222293e41 100644 --- a/DEPS +++ b/DEPS @@ -152,7 +152,7 @@ deps = { Var('fuchsia_git') + '/third_party/benchmark' + '@' + 'a779ffce872b4c811beef482e18bd0b63626aa42', 'src/third_party/googletest': - Var('fuchsia_git') + '/third_party/googletest' + '@' + '46d66506083fc3333d84c260e7bd2eb3816a917a', + Var('fuchsia_git') + '/third_party/googletest' + '@' + 'd8827ca8e397b725a3039b19cc116e309c47815e', 'src/third_party/rapidjson': Var('fuchsia_git') + '/third_party/rapidjson' + '@' + '32d07c55db1bb6c2ae17cba4033491a667647753', diff --git a/ci/licenses_golden/licenses_flutter b/ci/licenses_golden/licenses_flutter index c579896589212..8e21402b2bb5b 100644 --- a/ci/licenses_golden/licenses_flutter +++ b/ci/licenses_golden/licenses_flutter @@ -942,6 +942,7 @@ FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner.cc FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner.h FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner_context.cc FILE: ../../../flutter/shell/platform/fuchsia/flutter/runner_context.h +FILE: ../../../flutter/shell/platform/fuchsia/flutter/sample_unittests.cc FILE: ../../../flutter/shell/platform/fuchsia/flutter/service_provider_dir.cc FILE: ../../../flutter/shell/platform/fuchsia/flutter/service_provider_dir.h FILE: ../../../flutter/shell/platform/fuchsia/flutter/session_connection.cc diff --git a/shell/platform/fuchsia/flutter/BUILD.gn b/shell/platform/fuchsia/flutter/BUILD.gn index 90ba1e87b5c30..197921e98aa55 100644 --- a/shell/platform/fuchsia/flutter/BUILD.gn +++ b/shell/platform/fuchsia/flutter/BUILD.gn @@ -336,3 +336,40 @@ jit_runner("flutter_jit_runner") { jit_runner("flutter_jit_product_runner") { product = true } + +executable("flutter_runner_unittests") { + testonly = true + + output_name = "flutter_runner_tests" + + sources = [ + "sample_unittests.cc", + ] + + # This is needed for //third_party/googletest for linking zircon + # symbols. + libs = [ "//fuchsia/sdk/$host_os/arch/$target_cpu/sysroot/lib/libzircon.so" ] + + deps = [ + "//flutter/testing", + ] +} + +package_dir("flutter_runner_tests") { + testonly = true + + deps = [ + ":flutter_runner_unittests", + ] + + binary = "$target_name" + + meta_dir = "$flutter_root/shell/platform/fuchsia/flutter/meta" + + meta = [ + { + path = "meta/$target_name.cmx" + dest = "$target_name.cmx" + }, + ] +} diff --git a/shell/platform/fuchsia/flutter/sample_unittests.cc b/shell/platform/fuchsia/flutter/sample_unittests.cc new file mode 100644 index 0000000000000..fd796edb3b804 --- /dev/null +++ b/shell/platform/fuchsia/flutter/sample_unittests.cc @@ -0,0 +1,15 @@ +// Copyright 2013 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "gtest/gtest.h" + +namespace flutter { +namespace testing { + +TEST(FlutterRunnerSampleTest, Sample) { + ASSERT_TRUE(true); +} + +} // namespace testing +} // namespace flutter