From cf768254fd2d34751eb263453ae8aaed614fb61a Mon Sep 17 00:00:00 2001 From: Jens Johansen Date: Thu, 28 Mar 2019 09:59:29 +0000 Subject: [PATCH] Temporarily disable 'Allow the incremental compiler to load modules' Caused weird test failures. Disabling while investigating. Change-Id: I566a209175a1ad6a4384ee815f54ba04bdb75570 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98120 Reviewed-by: Jens Johansen --- pkg/front_end/lib/src/fasta/incremental_compiler.dart | 2 +- .../testcases/incremental_initialize_from_dill/status.status | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/front_end/lib/src/fasta/incremental_compiler.dart b/pkg/front_end/lib/src/fasta/incremental_compiler.dart index dedefe9cbaec0..6f1b22d509dfa 100644 --- a/pkg/front_end/lib/src/fasta/incremental_compiler.dart +++ b/pkg/front_end/lib/src/fasta/incremental_compiler.dart @@ -227,7 +227,7 @@ class IncrementalCompiler implements IncrementalKernelGenerator { CompilerContext.current.uriToSource.remove(builder.fileUri); } - if (hasToCheckPackageUris) { + if (hasToCheckPackageUris && false) { // The package file was changed. // Make sure the dill loader is on the same page. DillTarget oldDillLoadedData = dillLoadedData; diff --git a/pkg/front_end/testcases/incremental_initialize_from_dill/status.status b/pkg/front_end/testcases/incremental_initialize_from_dill/status.status index f3d01d2eaefb1..bc230d5350eb1 100644 --- a/pkg/front_end/testcases/incremental_initialize_from_dill/status.status +++ b/pkg/front_end/testcases/incremental_initialize_from_dill/status.status @@ -3,3 +3,4 @@ # BSD-style license that can be found in the LICENSE.md file. # Status file for the test suite ../test/incremental_load_from_dill_yaml_test.dart. +changing_modules: Crash