From 101abba34228bdb8ba01b648a364aa45bdcfe46d Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Thu, 12 Dec 2019 07:41:43 -0800 Subject: [PATCH 1/3] Add hint to analyzer regarding unused field. --- lib/ui/painting.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ui/painting.dart b/lib/ui/painting.dart index a6c96ac929884..88fad3b199aa1 100644 --- a/lib/ui/painting.dart +++ b/lib/ui/painting.dart @@ -2633,6 +2633,7 @@ class ColorFilter { // The type of SkColorFilter class to create for Skia. // These constants must be kept in sync with ColorFilterType in paint.cc. + // ignore:unused_field static const int _TypeNone = 0; // null static const int _TypeMode = 1; // MakeModeFilter static const int _TypeMatrix = 2; // MakeMatrixFilterRowMajor255 From 2883aceb8bc7e471d353790d8a654d75d55e4683 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Thu, 12 Dec 2019 08:29:17 -0800 Subject: [PATCH 2/3] Remove unused field --- lib/ui/painting.dart | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/ui/painting.dart b/lib/ui/painting.dart index 88fad3b199aa1..33d209486f6d1 100644 --- a/lib/ui/painting.dart +++ b/lib/ui/painting.dart @@ -2632,9 +2632,6 @@ class ColorFilter { final int _type; // The type of SkColorFilter class to create for Skia. - // These constants must be kept in sync with ColorFilterType in paint.cc. - // ignore:unused_field - static const int _TypeNone = 0; // null static const int _TypeMode = 1; // MakeModeFilter static const int _TypeMatrix = 2; // MakeMatrixFilterRowMajor255 static const int _TypeLinearToSrgbGamma = 3; // MakeLinearToSRGBGamma From 1bc67e8ed1be4b53079afffc08ed505bd08363f9 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Thu, 12 Dec 2019 08:40:29 -0800 Subject: [PATCH 3/3] Similarly remove _TypeNone from web_ui --- lib/web_ui/lib/src/engine/color_filter.dart | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/web_ui/lib/src/engine/color_filter.dart b/lib/web_ui/lib/src/engine/color_filter.dart index 48e4b8bb60863..c6dcf8e1a9088 100644 --- a/lib/web_ui/lib/src/engine/color_filter.dart +++ b/lib/web_ui/lib/src/engine/color_filter.dart @@ -114,8 +114,6 @@ class EngineColorFilter implements ui.ColorFilter { final int _type; // The type of SkColorFilter class to create for Skia. - // These constants must be kept in sync with ColorFilterType in paint.cc. - static const int _TypeNone = 0; // null static const int _TypeMode = 1; // MakeModeFilter static const int _TypeMatrix = 2; // MakeMatrixFilterRowMajor255 static const int _TypeLinearToSrgbGamma = 3; // MakeLinearToSRGBGamma