Revert "Wire up Opacity on Fuchsia, round 2 (#14024)" #14543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
requested review from
chinmaygarde
and removed request for
GaryQian
chinmaygarde
approved these changes
Dec 18, 2019
iskakaushik
force-pushed
the
rev-dw-ch
branch
3 times, most recently
from
219d0f4 to
712572a
Compare
|
@chinmaygarde I was able to get all tests other than |
|
It is a pixel test. It says "Image did not match expectation" and prints the location of the expectation vs the actual image. Reverting this patch makes the test pass. This is not a flake and looks like a real failure. Was this just a straight revert or did you have to change anything else to get this to build? |
This reverts commit d117ac9.
iskakaushik
force-pushed
the
rev-dw-ch
branch
from
712572a to
f33da10
Compare
|
This wasn't a clean revert. The test (rightly before the revert) assumed that the scene builder would start with a container layer. The revert violates this invariant. I restored the behavior and now the test should pass. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 18, 2019
chingjun
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2019
* fa1adf4 Roll src/third_party/dart c9d89d55a60e..6fcd1de98c2c (8 commits) (flutter/engine#14551) * 6ea69a0 Revert "Wire up Opacity on Fuchsia, round 2 (#14024)" (flutter/engine#14543) * 1e1f371 Roll src/third_party/dart 6fcd1de98c2c..270966b16044 (7 commits) (flutter/engine#14553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d117ac9.