Reland "[web] Calculate align offset for each paragraph line (LineMetrics.left)" (#14537) #15151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jan 6, 2020
mdebbar
force-pushed
the
reland_align_offset
branch
from
d99e6da to
cf45aba
Compare
mdebbar
force-pushed
the
reland_align_offset
branch
from
cf45aba to
7e612c9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
This was referenced Jan 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
…(LineMetrics.left)" (flutter#14537) (flutter/engine#15151)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…(LineMetrics.left)" (flutter#14537) (flutter#15151)" This reverts commit a2bd950.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #14537
Reverted in: #14569
Changes: I removed the assertions checking for null values and replaced them with default values.