diff --git a/.clang-tidy b/.clang-tidy index 7947394ce3950..bbcce4fe1497e 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -29,6 +29,7 @@ readability-identifier-naming,\ clang-diagnostic-*,\ google-objc-*,\ google-explicit-constructor,\ +google-readability-avoid-underscore-in-googletest-name,\ performance-move-const-arg,\ performance-unnecessary-value-param" diff --git a/display_list/display_list_image_filter_unittests.cc b/display_list/display_list_image_filter_unittests.cc index c447d52e81586..95807c061666b 100644 --- a/display_list/display_list_image_filter_unittests.cc +++ b/display_list/display_list_image_filter_unittests.cc @@ -653,7 +653,7 @@ TEST(DisplayListImageFilter, ComposeBoundsWithUnboundedInnerAndOuter) { } // See https://github.com/flutter/flutter/issues/108433 -TEST(DisplayListImageFilter, Issue_108433) { +TEST(DisplayListImageFilter, Issue108433) { auto input_bounds = SkIRect::MakeLTRB(20, 20, 80, 80); auto sk_filter = SkColorFilters::Blend(SK_ColorRED, SkBlendMode::kSrcOver); diff --git a/flow/raster_cache_unittests.cc b/flow/raster_cache_unittests.cc index d72b91abf3b1b..47f3e0b10e5f3 100644 --- a/flow/raster_cache_unittests.cc +++ b/flow/raster_cache_unittests.cc @@ -709,7 +709,7 @@ TEST(RasterCache, RasterCacheKeySameType) { ASSERT_EQ(map[layer_children_third_key], 300); } -TEST(RasterCache, RasterCacheKeyID_Equal) { +TEST(RasterCache, RasterCacheKeyIDEqual) { RasterCacheKeyID first = RasterCacheKeyID(1, RasterCacheKeyType::kLayer); RasterCacheKeyID second = RasterCacheKeyID(2, RasterCacheKeyType::kLayer); RasterCacheKeyID third = @@ -729,7 +729,7 @@ TEST(RasterCache, RasterCacheKeyID_Equal) { ASSERT_NE(fifth, sixth); } -TEST(RasterCache, RasterCacheKeyID_HashCode) { +TEST(RasterCache, RasterCacheKeyIDHashCode) { uint64_t foo = 1; uint64_t bar = 2; RasterCacheKeyID first = RasterCacheKeyID(foo, RasterCacheKeyType::kLayer); @@ -763,7 +763,7 @@ TEST(RasterCache, RasterCacheKeyID_HashCode) { using RasterCacheTest = SkiaGPUObjectLayerTest; -TEST_F(RasterCacheTest, RasterCacheKeyID_LayerChildrenIds) { +TEST_F(RasterCacheTest, RasterCacheKeyIDLayerChildrenIds) { auto layer = std::make_shared(); const SkPath child_path = SkPath().addRect(SkRect::MakeWH(5.0f, 5.0f)); diff --git a/shell/platform/embedder/tests/embedder_unittests.cc b/shell/platform/embedder/tests/embedder_unittests.cc index 74f6c4a563731..e9616336a598a 100644 --- a/shell/platform/embedder/tests/embedder_unittests.cc +++ b/shell/platform/embedder/tests/embedder_unittests.cc @@ -1629,44 +1629,55 @@ static void expectSoftwareRenderingOutputMatches( std::vector(bytes, bytes + sizeof(T))); } -#define SW_PIXFMT_TEST_F(dart_entrypoint, pixfmt, matcher) \ - TEST_F(EmbedderTest, \ - SoftwareRenderingPixelFormats_##dart_entrypoint##_##pixfmt) { \ +#define SW_PIXFMT_TEST_F(test_name, dart_entrypoint, pixfmt, matcher) \ + TEST_F(EmbedderTest, SoftwareRenderingPixelFormats##test_name) { \ expectSoftwareRenderingOutputMatches(*this, #dart_entrypoint, pixfmt, \ matcher); \ } // Don't test the pixel formats that contain padding (so an X) and the kNative32 // pixel format here, so we don't add any flakiness. -SW_PIXFMT_TEST_F(draw_solid_red, kRGB565, (uint16_t)0xF800); -SW_PIXFMT_TEST_F(draw_solid_red, kRGBA4444, (uint16_t)0xF00F); -SW_PIXFMT_TEST_F(draw_solid_red, +SW_PIXFMT_TEST_F(RedRGBA565xF800, draw_solid_red, kRGB565, (uint16_t)0xF800); +SW_PIXFMT_TEST_F(RedRGBA4444xF00F, draw_solid_red, kRGBA4444, (uint16_t)0xF00F); +SW_PIXFMT_TEST_F(RedRGBA8888xFFx00x00xFF, + draw_solid_red, kRGBA8888, (std::vector{0xFF, 0x00, 0x00, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_red, +SW_PIXFMT_TEST_F(RedBGRA8888x00x00xFFxFF, + draw_solid_red, kBGRA8888, (std::vector{0x00, 0x00, 0xFF, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_red, kGray8, (uint8_t)0x36); - -SW_PIXFMT_TEST_F(draw_solid_green, kRGB565, (uint16_t)0x07E0); -SW_PIXFMT_TEST_F(draw_solid_green, kRGBA4444, (uint16_t)0x0F0F); -SW_PIXFMT_TEST_F(draw_solid_green, +SW_PIXFMT_TEST_F(RedGray8x36, draw_solid_red, kGray8, (uint8_t)0x36); + +SW_PIXFMT_TEST_F(GreenRGB565x07E0, draw_solid_green, kRGB565, (uint16_t)0x07E0); +SW_PIXFMT_TEST_F(GreenRGBA4444x0F0F, + draw_solid_green, + kRGBA4444, + (uint16_t)0x0F0F); +SW_PIXFMT_TEST_F(GreenRGBA8888x00xFFx00xFF, + draw_solid_green, kRGBA8888, (std::vector{0x00, 0xFF, 0x00, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_green, +SW_PIXFMT_TEST_F(GreenBGRA8888x00xFFx00xFF, + draw_solid_green, kBGRA8888, (std::vector{0x00, 0xFF, 0x00, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_green, kGray8, (uint8_t)0xB6); - -SW_PIXFMT_TEST_F(draw_solid_blue, kRGB565, (uint16_t)0x001F); -SW_PIXFMT_TEST_F(draw_solid_blue, kRGBA4444, (uint16_t)0x00FF); -SW_PIXFMT_TEST_F(draw_solid_blue, +SW_PIXFMT_TEST_F(GreenGray8xB6, draw_solid_green, kGray8, (uint8_t)0xB6); + +SW_PIXFMT_TEST_F(BlueRGB565x001F, draw_solid_blue, kRGB565, (uint16_t)0x001F); +SW_PIXFMT_TEST_F(BlueRGBA4444x00FF, + draw_solid_blue, + kRGBA4444, + (uint16_t)0x00FF); +SW_PIXFMT_TEST_F(BlueRGBA8888x00x00xFFxFF, + draw_solid_blue, kRGBA8888, (std::vector{0x00, 0x00, 0xFF, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_blue, +SW_PIXFMT_TEST_F(BlueBGRA8888xFFx00x00xFF, + draw_solid_blue, kBGRA8888, (std::vector{0xFF, 0x00, 0x00, 0xFF})); -SW_PIXFMT_TEST_F(draw_solid_blue, kGray8, (uint8_t)0x12); +SW_PIXFMT_TEST_F(BlueGray8x12, draw_solid_blue, kGray8, (uint8_t)0x12); //------------------------------------------------------------------------------ // Key Data