This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing header guards #41322
Merged
Add missing header guards #41322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
zanderso
approved these changes
Apr 19, 2023
chinmaygarde
approved these changes
Apr 19, 2023
common/constants.h
Outdated
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #pragma once |
Member
There was a problem hiding this comment.
Some packages use define guards while others use pragmas. It would be good to be consistent with other headers in the package.
But this is definitely an improvement.
bdero
force-pushed
the
bdero/header-guards
branch
from
c0dc616 to
b836093
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 20, 2023
…125183) flutter/engine@d726345...2db85cb 2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352) 2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349) 2023-04-19 bdero@google.com Add missing header guards (flutter/engine#41322) 2023-04-19 joshualitt@google.com [web] Fix trivial type issue. (flutter/engine#40956) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These keep turning up, so I did a little bash-fu to find them all.