This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix use of nested designators #45869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jiahaog
force-pushed
the
fix-c99-designator
branch
from
8742863 to
7e061d6
Compare
cbracken
approved these changes
Oct 19, 2023
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2023
…136915) flutter/engine@bfd2ffb...b40042e 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118) 2023-10-19 jiahaog@users.noreply.github.com Fix use of nested designators (flutter/engine#45869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jiahaog
added a commit
to jiahaog/flutter-buildroot
that referenced
this pull request
Oct 20, 2023
flutter/engine#45869 may have removed the last occurrence of this.
8 tasks
auto-submit bot
pushed a commit
to flutter/buildroot
that referenced
this pull request
Oct 20, 2023
flutter/engine#45869 may have removed the last occurrence of this. *List which issues are fixed by this PR. You must list at least one issue.* b/300573112
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
See also: - #45869 - flutter/buildroot#788 *List which issues are fixed by this PR. You must list at least one issue.* b/300573112
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
There was an internal global change which turned `-Wc99-designator`. This causes the following error:
```
error: nested designators are a C99 extension [-Werror,-Wc99-designator]
65 | .metal.struct_size = sizeof(FlutterMetalRendererConfig),
| ^~~~~~~~~~~~~~~~~~
```
This seems like a trivial (?) fix, so perhaps we can fix it properly and possibly remove https://github.com/flutter/buildroot/blob/b9fbd310d6fa68f888738d5236ea2f6caa2d2bfc/build/config/compiler/BUILD.gn#L667 after this PR lands.
*List which issues are fixed by this PR. You must list at least one issue.*
b/300573112
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
See also: - #45869 - flutter/buildroot#788 *List which issues are fixed by this PR. You must list at least one issue.* b/300573112
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an internal global change which turned
-Wc99-designator. This causes the following error:This seems like a trivial (?) fix, so perhaps we can fix it properly and possibly remove https://github.com/flutter/buildroot/blob/b9fbd310d6fa68f888738d5236ea2f6caa2d2bfc/build/config/compiler/BUILD.gn#L667 after this PR lands.
List which issues are fixed by this PR. You must list at least one issue.
b/300573112
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.