This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run tests on macOS 13 exclusively #49099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Dec 15, 2023
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…140244) flutter/engine@a8d861b...6e3a048 2023-12-15 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 exclusively (flutter/engine#49099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
This reverts commit 6e3a048.
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Dec 15, 2023
Reverts #49099 Initiated by: vashworth This change reverts the following previous change: Original Description: Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Contributor
Author
|
Reverting. Apparently we need macOS 13 bots in an internal pool before we can do this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.