Move the accesibility placeholder to the platform dispatcher. #50608
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tugorez
added
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
https://flutter-web-20c94.web.app this is a testing app with these changes that can be used to perform manual verifications cc @yjbanov |
tugorez
added
the
autosubmit
…143565) flutter/engine@b7103bc...dd530f1 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708) 2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676) 2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693) 2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704) 2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 2024-02-15 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694) 2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687) 2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Move the accesibility placeholder to the platform dispatcher.
This change makes the platform dispatcher append a single accesibility placeholder, per app, to the
<body />. Previous behavior was to insert a placeholder inside each<flutter-view />Relevant Issues are:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.