Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Mar 6, 2024

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2024

auto label is removed for flutter/engine/51231, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2024

auto label is removed for flutter/engine/51231, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto-submit auto-submit bot merged commit 3ef6c53 into main Mar 6, 2024
@auto-submit auto-submit bot deleted the zanderso-patch-5 branch March 6, 2024 20:27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 6, 2024
…144724)

flutter/engine@5bbac1a...31bbe61

2024-03-06 flar@google.com add new builder benchmark with a global saveLayer (flutter/engine#51236)
2024-03-06 bdero@google.com [Flutter GPU] Move method tests to flutter_tester. (flutter/engine#51223)
2024-03-06 zanderso@users.noreply.github.com Disable flaky linux desktop test (flutter/engine#51231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants