This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor BuildPlan, better document and explain --config.
#56324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Nov 1, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, just a few notes on documentation
| }); | ||
| } | ||
|
|
||
| /// Creates a final listing of builds from a mapping of builds. |
Member
There was a problem hiding this comment.
FWIW it isn't clear what this does from here. I'd say `Extracts [Build]s from [runnableConfigs] that can execute on [platform].
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 2, 2024
…158038) flutter/engine@38b6165...05cb5d7 2024-11-02 matanlurey@users.noreply.github.com Refactor `BuildPlan`, better document and explain `--config`. (flutter/engine#56324) 2024-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... (flutter/engine#56322) 2024-11-01 jonahwilliams@google.com [Impeller] implement external texture gl for embedder. (flutter/engine#56277) 2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 789763468d6b to 61bf0877807e (2 revisions) (flutter/engine#56323) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from MjcuejuzYvYG to 07KmbdEtnhkg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…r/engine#56324) Closes flutter#156591. Closes flutter#156355. I also moved some functions only used as implementation details :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#156591.
Closes flutter/flutter#156355.
I also moved some functions only used as implementation details :)