-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libtxt unit tests #6111
Merged
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:txt_unittests_0829
Aug 29, 2018
Merged
Fix libtxt unit tests #6111
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:txt_unittests_0829
Aug 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 29, 2018
LGTM |
cbracken
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2018
flutter/engine@a02a94e...4a69907 git log a02a94e..4a69907 --no-merges --oneline 4a69907 Fix libtxt unit tests (flutter/engine#6111) c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106) 9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2018
flutter/engine@a02a94e...7a59965 git log a02a94e..7a59965 --no-merges --oneline 7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115) 4a69907 Fix libtxt unit tests (flutter/engine#6111) c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106) 9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 29, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2018
flutter/engine@a02a94e...cba35d3 git log a02a94e..cba35d3 --no-merges --oneline cba35d3 Roll Tonic (flutter/engine#6114) 7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115) 4a69907 Fix libtxt unit tests (flutter/engine#6111) c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106) 9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2018
flutter/engine@a02a94e...252da48 git log a02a94e..252da48 --no-merges --oneline 252da48 Roll src/third_party/skia 1b714becff8b..eb0bb732f43f (2 commits) (flutter/engine#6116) cba35d3 Roll Tonic (flutter/engine#6114) 7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115) 4a69907 Fix libtxt unit tests (flutter/engine#6111) c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106) 9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2018
flutter/engine@a02a94e...252da48 git log a02a94e..252da48 --no-merges --oneline 252da48 Roll src/third_party/skia 1b714becff8b..eb0bb732f43f (2 commits) (flutter/engine#6116) cba35d3 Roll Tonic (flutter/engine#6114) 7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115) 4a69907 Fix libtxt unit tests (flutter/engine#6111) c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106) 9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.