Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libtxt unit tests #6111

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

jason-simmons
Copy link
Member

No description provided.

@jason-simmons
Copy link
Member Author

@GaryQian

@GaryQian
Copy link
Contributor

LGTM

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jason-simmons jason-simmons merged commit 4a69907 into flutter:master Aug 29, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2018
flutter/engine@a02a94e...4a69907

git log a02a94e..4a69907 --no-merges --oneline
4a69907 Fix libtxt unit tests (flutter/engine#6111)
c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106)
9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2018
flutter/engine@a02a94e...7a59965

git log a02a94e..7a59965 --no-merges --oneline
7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115)
4a69907 Fix libtxt unit tests (flutter/engine#6111)
c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106)
9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 29, 2018
flutter/engine@a02a94e...cba35d3

git log a02a94e..cba35d3 --no-merges --oneline
cba35d3 Roll Tonic (flutter/engine#6114)
7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115)
4a69907 Fix libtxt unit tests (flutter/engine#6111)
c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106)
9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 30, 2018
flutter/engine@a02a94e...252da48

git log a02a94e..252da48 --no-merges --oneline
252da48 Roll src/third_party/skia 1b714becff8b..eb0bb732f43f (2 commits) (flutter/engine#6116)
cba35d3 Roll Tonic (flutter/engine#6114)
7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115)
4a69907 Fix libtxt unit tests (flutter/engine#6111)
c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106)
9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 30, 2018
flutter/engine@a02a94e...252da48

git log a02a94e..252da48 --no-merges --oneline
252da48 Roll src/third_party/skia 1b714becff8b..eb0bb732f43f (2 commits) (flutter/engine#6116)
cba35d3 Roll Tonic (flutter/engine#6114)
7a59965 Roll src/third_party/skia 1f0fb09d5e35..1b714becff8b (11 commits) (flutter/engine#6115)
4a69907 Fix libtxt unit tests (flutter/engine#6111)
c765bee Fix tilt by using custom normalize impl to avoid strange skia normalize behavior (flutter/engine#6106)
9fde6e0 Roll src/third_party/skia a81c2be75adc..1f0fb09d5e35 (13 commits) (flutter/engine#6110)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants